Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Apr 2017 23:32:57 +0000 (UTC)
From:      Rick Macklem <rmacklem@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org
Subject:   svn commit: r317477 - stable/9/sys/fs/nfsclient
Message-ID:  <201704262332.v3QNWvZI033153@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rmacklem
Date: Wed Apr 26 23:32:57 2017
New Revision: 317477
URL: https://svnweb.freebsd.org/changeset/base/317477

Log:
  MFC: r316667
  Fix the NFSv4 client hndling of a stale write verifier in the Commit operation.
  
  When the NFSv4 client Commit operation encountered a stale write verifier,
  it erroneously mapped that to EIO. This could have caused recently written
  data to be lost when a server crashes/reboots between an UNSTABLE write
  and the subsequent commit. This patch fixes this.
  The bug was only for the NFSv4 client and did not affect NFSv3.

Modified:
  stable/9/sys/fs/nfsclient/nfs_clport.c
Directory Properties:
  stable/9/sys/   (props changed)
  stable/9/sys/fs/   (props changed)

Modified: stable/9/sys/fs/nfsclient/nfs_clport.c
==============================================================================
--- stable/9/sys/fs/nfsclient/nfs_clport.c	Wed Apr 26 23:24:05 2017	(r317476)
+++ stable/9/sys/fs/nfsclient/nfs_clport.c	Wed Apr 26 23:32:57 2017	(r317477)
@@ -1129,7 +1129,7 @@ nfscl_maperr(struct thread *td, int erro
 {
 	struct proc *p;
 
-	if (error < 10000)
+	if (error < 10000 || error >= NFSERR_STALEWRITEVERF)
 		return (error);
 	if (td != NULL)
 		p = td->td_proc;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704262332.v3QNWvZI033153>