Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 6 May 1999 15:08:06 -0600 (MDT)
From:      "Kenneth D. Merry" <ken@plutotech.com>
To:        hibma@skylink.it
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sbin/camcontrol camcontrol.8 camcontrol.c         src/sys/cam cam_ccb.h cam_sim.c cam_sim.h cam_xpt.c
Message-ID:  <199905062108.PAA47056@panzer.plutotech.com>
In-Reply-To: <Pine.BSF.3.96.990506222513.731D-100000@heidi.plazza.it> from Nick Hibma at "May 6, 1999 10:55:11 pm"

next in thread | previous in thread | raw e-mail | index | archive | help
Nick Hibma wrote...
> 
> The change in vpo.c was
> 
> @@ -421,6 +421,7 @@
>                 cpi->max_lun = 0;
>                 cpi->initiator_id = VP0_INITIATOR;
>                 cpi->bus_id = sim->bus_id;
> +               cpi->base_transfer_speed = 3300;
>                 strncpy(cpi->sim_vid, "FreeBSD", SIM_IDLEN);
>                 strncpy(cpi->hba_vid, "Iomega", HBA_IDLEN);
>                 strncpy(cpi->dev_name, sim->sim_name, DEV_IDLEN);
> 
> 
> What about the call to
> 
>         cam_sim_set_basexfer_speed(vpo->sim, 93/*kB/s*/);
> 
> should it be removed?

Oops!  Yes, it should.

> Second, the 3300 is quite different from the 93 kb/s. This looks a
> cut&paste bogon. 93kb/s is more like perceived performance on ppbus.

I didn't realize that that was the case.

> Just asking because the dev/usb/umass driver needs updating as well
> (iomega USB Zip drive driver).

Ahh, okay.  Sorry about that, I don't think the umass driver was even in
the tree when I started these changes...

If you don't mind, I'll go ahead and make these changes, since I'll need to
make the same changes to the -stable tree when I check things in.

Ken
-- 
Kenneth Merry
ken@plutotech.com


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199905062108.PAA47056>