Date: Mon, 7 Oct 2019 14:17:19 +0200 From: =?UTF-8?B?VMSzbA==?= Coosemans <tijl@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r513618 - head/devel/scons Message-ID: <20191007141714.51f9a172@FreeBSD.org> In-Reply-To: <20191007082934.outquwlqf7fowryg@atuin.in.mat.cc> References: <201910021951.x92Jp5R7080254@repo.freebsd.org> <20191006180248.0d7744df@FreeBSD.org> <20191007082934.outquwlqf7fowryg@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 7 Oct 2019 10:29:34 +0200 Mathieu Arnold <mat@FreeBSD.org> wrote: > On Sun, Oct 06, 2019 at 06:02:48PM +0200, T=C4=B3l Coosemans wrote: >> On Wed, 2 Oct 2019 19:51:05 +0000 (UTC) Sunpoet Po-Chuan Hsieh >> <sunpoet@FreeBSD.org> wrote: =20 >>> Author: sunpoet >>> Date: Wed Oct 2 19:51:04 2019 >>> New Revision: 513618 >>> URL: https://svnweb.freebsd.org/changeset/ports/513618 >>>=20 >>> Log: >>> Update to 3.1.1 >>> =20 >>> Changes: https://scons.org/tag/releases.html >>> https://github.com/SCons/scons/blob/master/src/CHANGES.txt >>> PR: 240584 >>> Exp-run by: antoine >>>=20 >>> Modified: >>> head/devel/scons/Makefile >>> head/devel/scons/distinfo >>>=20 >>> Modified: head/devel/scons/Makefile >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/devel/scons/Makefile Wed Oct 2 19:50:04 2019 (r513617) >>> +++ head/devel/scons/Makefile Wed Oct 2 19:51:04 2019 (r513618) >>> @@ -2,7 +2,7 @@ >>> # $FreeBSD$ >>> =20 >>> PORTNAME=3D scons >>> -PORTVERSION=3D 3.0.1 >>> +PORTVERSION=3D 3.1.1 >>> CATEGORIES=3D devel python >>> MASTER_SITES=3D SF >>> =20 >>> @@ -15,17 +15,16 @@ LICENSE_FILE=3D ${WRKSRC}/LICENSE.txt >>> RUN_DEPENDS=3D gm4:devel/m4 >>> =20 >>> USES=3D python:2.7 shebangfix >>> -SHEBANG_FILES=3D script/scons* >>> -USE_PYTHON=3D distutils autoplist >>> +USE_PYTHON=3D autoplist distutils =20 >>=20 >> It's probably a bug in portmaster but currently it always rebuilds >> flavored ports (even if there isn't a new version) if the *_DEPENDS line >> doesn't specify which flavor is needed. Can you either add @py27 to the >> BUILD_DEPENDS line in Mk/Uses/scons.mk or add USE_PYTHON=3Dnoflavors her= e? >> If scons only supports one version of python I guess it doesn't need to >> be flavored. =20 >=20 > I is a bug in portmaster. If the depends line does not specify the > flavor, it means the default (first) flavor needs to be used, always. >=20 > I do not think adding shims in the ports tree to fix badly behaving > third party tools is a very good idea, or sets a good precedent. But the question remains, does this port need flavors? Most ports that install python scripts don't seem to be flavored. devel/meson for instance is a build system like scons and it has USE_PYTHON=3Dnoflavors.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191007141714.51f9a172>