Date: Fri, 21 Feb 2003 10:45:57 -0800 From: Terry Lambert <tlambert2@mindspring.com> To: omestre <omestre@SDF.LONESTAR.ORG> Cc: freebsd-hackers@freebsd.org Subject: Re: bootp_subr.c patch Message-ID: <3E5673E5.7AAEBEAA@mindspring.com> References: <Pine.NEB.4.33.0302211749580.8639-100000@sdf.lonestar.org>
next in thread | previous in thread | raw e-mail | index | archive | help
omestre wrote:
> + * Copyright (c) 2002 Marcelo Leal
This is generally frowned upon, but not strictly prohibited, if the
code changes are significant.
> - * This product includes software developed by the University of
> - * California, Lawrence Berkeley Laboratory and its contributors.
> + * This product includes software developed by the University of
> + * California, Lawrence Berkeley Laboratory and its contributors.
This is just plain gratuitous.
> - * $NetBSD: krpc_subr.c,v 1.10 1995/08/08 20:43:43 gwr Exp $
> + * $NetBSD: krpc_subr.c,v 1.10 1995/08/08 20:43:43 gwr Exp $
Uh... FreeBSD.
> @@ -56,14 +57,11 @@
> #include <sys/socketvar.h>
> #include <sys/sysctl.h>
> #include <sys/uio.h>
> -
> #include <net/if.h>
> #include <net/route.h>
> -
[ ... ]
Gratuitous.
[ ... rest of patch: mostly inoffensive ... ]
> + /* The start... */
> + printf("---------------------------------FILE HANDLE PATCH\n", "%s");
> + printf("\033\[01\;34mCia de Processamento de Dados do Rio Grande do
> Sul\033\[0m\n", "%s");
> + printf("--------------------------------------------------\n", "%s");
> + setup_nfsdiskless();
> + printf("--------------------------------------------------\n", "%s");
...except this part.
1) Adding a printed copyright is really unacceptable.
2) Putting out a huge visual block is annoying; not only does the
user not care to know this, the static strings are useless
repetitive and long, in an area where data space is at a
premium.
3) Use of ANSI escape sequences assumes a console that can
interpret them; not all consoles will be able to do so, so
this is prohibited, period.
-- Terry
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3E5673E5.7AAEBEAA>