Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 25 Jun 2019 06:14:01 +0000 (UTC)
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r349354 - head/sys/fs/smbfs
Message-ID:  <201906250614.x5P6E1Dh062190@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: imp
Date: Tue Jun 25 06:14:00 2019
New Revision: 349354
URL: https://svnweb.freebsd.org/changeset/base/349354

Log:
  Replay r349334 by markj accidentally reverted by r349352
  
  Remove a lingering use of splbio().
  
  The buffer must be locked by the caller.  No functional change
  intended.
  
  Reviewed by:	kib
  MFC after:	1 week
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/sys/fs/smbfs/smbfs_io.c

Modified: head/sys/fs/smbfs/smbfs_io.c
==============================================================================
--- head/sys/fs/smbfs/smbfs_io.c	Tue Jun 25 06:13:56 2019	(r349353)
+++ head/sys/fs/smbfs/smbfs_io.c	Tue Jun 25 06:14:00 2019	(r349354)
@@ -375,9 +375,6 @@ smbfs_doio(struct vnode *vp, struct buf *bp, struct uc
 		 */
 		if (error == EINTR
 		    || (!error && (bp->b_flags & B_NEEDCOMMIT))) {
-			int s;
-
-			s = splbio();
 			bp->b_flags &= ~(B_INVAL|B_NOCACHE);
 			if ((bp->b_flags & B_ASYNC) == 0)
 			    bp->b_flags |= B_EINTR;
@@ -387,7 +384,6 @@ smbfs_doio(struct vnode *vp, struct buf *bp, struct uc
 			}
 			if ((bp->b_flags & B_ASYNC) == 0)
 			    bp->b_flags |= B_EINTR;
-			splx(s);
 		} else {
 			if (error) {
 				bp->b_ioflags |= BIO_ERROR;

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201906250614.x5P6E1Dh062190>