Date: Wed, 20 Oct 2010 09:23:34 -0700 From: Marcel Moolenaar <xcllnt@mac.com> To: "Andrey V. Elsukov" <bu7cher@yandex.ru> Cc: FreeBSD Current <freebsd-current@FreeBSD.ORG>, d@delphij.net Subject: Re: [zfs] Mounting from (...) failed with error 19 Message-ID: <EC698C9C-2017-4BA9-B6FD-863F30B35A2D@mac.com> In-Reply-To: <4CBE7254.5060502@yandex.ru> References: <4CBCDD3A.9070404@delphij.net> <4CBD26B4.2020205@yandex.ru> <4CBDB17C.4040607@yandex.ru> <44B33168-C432-4AA0-A765-8222DB4C048D@mac.com> <4CBE0BE5.2060708@delphij.net> <023E61D3-7E4C-4793-95A0-088ABCD0F92F@mac.com> <4CBE7254.5060502@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Oct 19, 2010, at 9:38 PM, Andrey V. Elsukov wrote: > On 20.10.2010 2:33, Marcel Moolenaar wrote: >>> What about the attached patch? I'm going to give it a swirl soon. The >>> difference is that it tests whether dev begins with /dev/. >> >> Interesting. I've been thinking about this too, but isn't >> exactly fool-proof. When devfs is the root file system, >> you can use "ufs:da0s1a" to refer to the device special >> file. It seems inconsistent to have "ufs:da0s1" fail when >> ufs:/dev/da0s1" works (a real scenario with USB based mass >> storage devices -- root mount is unheld as soon as umass >> is created, but before daX exists for it). >> >> This patch at least covers the problem cases with a single >> strstr(), and we may get away with the inconsistency given >> above by documenting it properly. >> >> Andrey: any thoughts? > > Currently usage information in parse_dir_ask() says that device should > be specified with "/dev/". But conf0 does not use "/dev/". Also, Marcel, > do you have any plans write some documentation with examples about using > of new features? Yes, this will be documented. -- Marcel Moolenaar xcllnt@mac.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EC698C9C-2017-4BA9-B6FD-863F30B35A2D>