Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 3 Apr 1997 10:20:58 +0900 (JST)
From:      Michael Hancock <michaelh@cet.co.jp>
To:        FreeBSD Hackers <Hackers@FreeBSD.ORG>
Subject:   factoring of vput/vrele not good
Message-ID:  <Pine.SV4.3.95.970403101452.1213A-100000@parkplace.cet.co.jp>

next in thread | raw e-mail | index | archive | help
I don't think the factoring of some of the common code in vput and vrele
into vputrele was a very good idea.  The problem is that the locking
semantics are very different which makes it tricky.  Tricky code is
*evil*.

Factoring is a good habit in many cases, but sometimes we need to look at
other aspects of code quality than processor cache efficiencies or
whatever benefit that was used to make this decision.

Regards,


Mike Hancock





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.SV4.3.95.970403101452.1213A-100000>