Date: Sun, 3 Jun 2018 12:04:45 +0200 From: Michael Tuexen <Michael.Tuexen@macmic.franken.de> To: Eitan Adler <eadler@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334554 - head/usr.bin/top Message-ID: <780B5AE9-CB7E-4668-9BF2-4E6FC62DD2E3@macmic.franken.de> In-Reply-To: <201806030602.w5362VuJ066716@repo.freebsd.org> References: <201806030602.w5362VuJ066716@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
top doesn't work on a amd64 (64 logical cores) and on an arm64 (8 cores) system anymore (world and kernel are in sync): tuexen@epyc:~ % uname -a FreeBSD epyc.nplab.de 12.0-CURRENT FreeBSD 12.0-CURRENT #5 r334554: Sun Jun 3 11:26:58 CEST 2018 root@epyc.nplab.de:/usr/obj/usr/home/tuexen/head/amd64.amd64/sys/GENERIC amd64 tuexen@epyc:~ % top top: sysctlbyname kern.cp_times: Cannot allocate memory FreeBSD bsd14.fh-muenster.de 12.0-CURRENT FreeBSD 12.0-CURRENT #16 r334554: Sun Jun 3 11:47:38 CEST 2018 root@bsd14.fh-muenster.de:/usr/obj/usr/home/tuexen/head/arm64.aarch64/sys/GENERIC arm64 tuexen@bsd14:~ % top top: sysctlbyname kern.cp_times: Cannot allocate memory Best regards Michael > On 3. Jun 2018, at 08:02, Eitan Adler <eadler@freebsd.org> wrote: > > Author: eadler > Date: Sun Jun 3 06:02:31 2018 > New Revision: 334554 > URL: https://svnweb.freebsd.org/changeset/base/334554 > > Log: > top(1): Only use NO_WERROR for base gcc > > This is what was intended. If statements are hard. > > Modified: > head/usr.bin/top/Makefile > > Modified: head/usr.bin/top/Makefile > ============================================================================== > --- head/usr.bin/top/Makefile Sun Jun 3 05:20:11 2018 (r334553) > +++ head/usr.bin/top/Makefile Sun Jun 3 06:02:31 2018 (r334554) > @@ -10,11 +10,13 @@ MAN= top.1 > > WARNS?= 6 > > -.if ${COMPILER_TYPE} == "gcc" && ${COMPILER_VERSION} >= 50000 > +.if ${COMPILER_TYPE} == "gcc" > +.if ${COMPILER_VERSION} >= 50000 > CFLAGS.gcc=-Wno-error=cast-align -Wno-error=cast-qual -Wno-error=discarded-qualifiers -Wno-error=incompatible-pointer-types \ > -Wno-error=maybe-uninitialized > .else #base gcc > NO_WERROR= > +.endif > .endif > CFLAGS.clang=-Wno-error=incompatible-pointer-types-discards-qualifiers -Wno-error=cast-qual -Wno-error=cast-align > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?780B5AE9-CB7E-4668-9BF2-4E6FC62DD2E3>