Date: Tue, 21 Jun 2011 17:04:56 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Sahil Tandon <sahil@tandon.net> Cc: Sahil Tandon <sahil@freebsd.org>, Wen Heping <wen@freebsd.org>, "cvs-all@freebsd.org" <cvs-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "bf1783@gmail.com" <bf1783@gmail.com>, "cvs-ports@freebsd.org" <cvs-ports@freebsd.org> Subject: Re: cvs commit: ports/sysutils/tmux Makefile Message-ID: <20110621170456.GA99757@FreeBSD.org> In-Reply-To: <64E6CAE2-1B3E-4A12-8103-1984DA9BB1E0@tandon.net> References: <201106160842.p5G8gS6T054738@repoman.freebsd.org> <20110616164733.GA40181@FreeBSD.org> <20110617004742.GD19139@magic.hamla.org> <BANLkTik344RMoiKtSejSxmEa14WNAR1x4Q@mail.gmail.com> <0C0893AE-B699-4DAB-AD58-C6075349DC2F@tandon.net> <BANLkTinsy9QqgFJ7kBHfMsQ77OnohM0O2w@mail.gmail.com> <64E6CAE2-1B3E-4A12-8103-1984DA9BB1E0@tandon.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 17, 2011 at 01:26:43PM -0400, Sahil Tandon wrote: > I think your passion about this "issue" is sweet. My (incredibly simple) > point is that unless we have a consensus, then going through and reverting > the tmux commit is really not needed. As been already mentioned, this commit is harmless, but bogus. For the reasons precisely explained by Brendan which you happen to find passionate and sweet when they are being very technical and thought through. Polluting our collection with plethora of ad-hoc "solutions" people are coming up with against their specific configurations is really not the way to go. If simple SOMEFLAGS+= assignment does not work, user's setup is tainted. We cannot possibly support every little corner case, we expect our users to know what they're doing when altering these kinds of things. I really hope that maintainer reworks the port to utilize simple CPPFLAGS+= and keeps it in their local tree so it can be committed when the port is touched next time. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110621170456.GA99757>