Date: Mon, 8 Mar 2004 13:20:33 +0300 From: Gleb Smirnoff <glebius@cell.sick.ru> To: Ruslan Ermilov <ru@FreeBSD.org>, julian@FreeBSD.org, archie@FreeBSD.org Cc: freebsd-net@FreeBSD.org Subject: Re: kern/63864: [patch] new control message for ng_iface(4) - getifindex Message-ID: <20040308102033.GA66247@cell.sick.ru> In-Reply-To: <200403072302.i27N2StR008804@freefall.freebsd.org> References: <200403072302.i27N2StR008804@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 07, 2004 at 03:02:28PM -0800, Ruslan Ermilov wrote: R> Synopsis: [patch] new control message for ng_iface(4) - getifindex R> R> State-Changed-From-To: open->closed R> State-Changed-By: ru R> State-Changed-When: Sun Mar 7 15:01:03 PST 2004 R> State-Changed-Why: R> Committed with tiny modifications, thanks! I have one more idea. Currently we have got 3 interface nodes: ng_ether, ng_iface, ng_eiface. 2 of them already support "getifindex" message, imagine I (or someone else) send you patch tomorrow, which adds support to ng_eiface. OK, now all three support. May be in future some new interface nodes will be developed. Imagine the following: you have node, which is connected to some generic interface (it doesn't know which node type exactly). This node wants to determine interface index of attached interfac. It would send 3 "getifindex" messages with 3 different cookies. Two of messages will always fail, and one return. This is not nice. What I suggest: create a new semi-generic cookie NGM_GENERICIFACE_COOKIE, which will be supported by all interface nodes. Put NGM_GENERICIFACE_GETIFINDEX message under NGM_GENERICIFACE_COOKIE case brackets. If you like this idea, please reply me. And I'll send patches. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040308102033.GA66247>