Date: Tue, 28 Jan 2003 01:04:37 -0800 From: Alfred Perlstein <bright@mu.org> To: current@freebsd.org Subject: LOR fix. Message-ID: <20030128090437.GL85104@elvis.mu.org>
next in thread | raw e-mail | index | archive | help
Since the locking is wrong anyhow...
Index: kern_descrip.c
===================================================================
RCS file: /home/ncvs/src/sys/kern/kern_descrip.c,v
retrieving revision 1.183
diff -u -r1.183 kern_descrip.c
--- kern_descrip.c 21 Jan 2003 20:20:48 -0000 1.183
+++ kern_descrip.c 28 Jan 2003 09:02:56 -0000
@@ -2104,8 +2104,8 @@
PROC_LOCK(p);
xf.xf_pid = p->p_pid;
xf.xf_uid = p->p_ucred->cr_uid;
+ PROC_UNLOCK(p);
if ((fdp = p->p_fd) == NULL) {
- PROC_UNLOCK(p);
continue;
}
FILEDESC_LOCK(fdp);
@@ -2125,7 +2125,6 @@
break;
}
FILEDESC_UNLOCK(fdp);
- PROC_UNLOCK(p);
if (error)
break;
}
--
-Alfred Perlstein [alfred@freebsd.org]
'Instead of asking why a piece of software is using "1970s technology,"
start asking why software is ignoring 30 years of accumulated wisdom.'
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030128090437.GL85104>