Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 23 Feb 2025 23:42:33 -0500
From:      Ian FREISLICH <ianfreislich@gmail.com>
To:        FreeBSD Current <current@freebsd.org>
Subject:   buildkernel failure in net/toeplitz.c (commit 3b281d1421a78b588c5fc4182009ce62d8823d95)
Message-ID:  <4858aa49-f102-49fc-90c7-9bd7480306c9@gmail.com>

index | next in thread | raw e-mail

Hi

Building a kernel today failed with:

-Werror /usr/src/sys/net/toeplitz.c
In file included from /usr/src/sys/net/toeplitz.c:29:
In file included from /usr/src/sys/net/rss_config.h:33:
/usr/src/sys/netinet/in.h:692:23: error: call to undeclared function 
'htonl'; ISO C99 and later do not support implicit function declarations 
[-Werror,-Wimplicit-function-declaration]
   692 |         return (in.s_addr == htonl(INADDR_BROADCAST) ||
       |                              ^
In file included from /usr/src/sys/net/toeplitz.c:32:
In file included from /usr/src/sys/sys/systm.h:98:
/usr/src/sys/sys/param.h:343:13: error: conflicting types for 'htonl'
   343 | __uint32_t       htonl(__uint32_t);
       |                  ^
/usr/src/sys/netinet/in.h:692:23: note: previous implicit declaration is 
here
   692 |         return (in.s_addr == htonl(INADDR_BROADCAST) ||

I think this is a result of changes to netinet/in.h (3b281d1421a78) 
which added a static inline function using ntohl() which is not defined 
in kernel use.

Ian


help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4858aa49-f102-49fc-90c7-9bd7480306c9>