Date: Tue, 25 Feb 2003 10:47:55 -0500 From: Craig Rodrigues <rodrigc@attbi.com> To: "Jacques A. Vidrine" <nectar@FreeBSD.org> Cc: markm@FreeBSD.org, freebsd-current@FreeBSD.org Subject: Re: OpenSSL should define OPENSSL_THREADS? Message-ID: <20030225154755.GA9400@attbi.com> In-Reply-To: <20030225132209.GB95282@madman.celabo.org> References: <20030225025821.GA4399@attbi.com> <20030225132209.GB95282@madman.celabo.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 25, 2003 at 07:22:09AM -0600, Jacques A. Vidrine wrote: > On Mon, Feb 24, 2003 at 09:58:21PM -0500, Craig Rodrigues wrote: > > Hi, > > > > I ran a cvsup of -CURRENT a few days ago. > > > > I have some code which assumes that OPENSSL_THREADS is defined if > > the OpenSSL version is greater than 0.9.7: > > Should the OpenSSL in FreeBSD be defining OPENSSL_THREADS? > > I think you may be right. OpenSSL 0.9.7's out-of-the box configure > creates an opensslconf.h that would define OPENSSL_THREADS on FreeBSD. > > Mark supplied the opensslconf.h's that are used in the FreeBSD build ... > let's see if this is intentional or not. [cc'd] These kind of macro changes can break backwards compatibility (OpenSSL's fault). If the intent is to minimize breakage of ports and such, I would not be opposed to do something like: #define OPENSSL_THREADS 1 #define THREADS OPENSSL_THREADS /** deprecated */ Would this work? -- Craig Rodrigues http://home.attbi.com/~rodrigc rodrigc@attbi.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030225154755.GA9400>