Date: Tue, 9 Sep 2025 19:54:02 +0100 From: Jessica Clarke <jrtc27@freebsd.org> To: James Gritton <jamie@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 16f600dc30b7 - main - jaildesc: replace EBADF with EINVAL Message-ID: <D83F304A-6226-4877-88D9-EADC628C3CE9@freebsd.org> In-Reply-To: <f28c46d3c051c6f6286b6c1822b4afb6@freebsd.org> References: <202509091818.589II2D2005924@gitrepo.freebsd.org> <9B159FF1-8D1D-4F1D-9CED-977EB0834403@freebsd.org> <f28c46d3c051c6f6286b6c1822b4afb6@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9 Sep 2025, at 19:52, James Gritton <jamie@freebsd.org> wrote: > On 2025-09-09 11:42, Jessica Clarke wrote: >> On 9 Sep 2025, at 19:18, Jamie Gritton <jamie@freebsd.org> wrote: >>> The branch main has been updated by jamie: >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D16f600dc30b7bb82429660e540da802a= 1e3f7449 >>> commit 16f600dc30b7bb82429660e540da802a1e3f7449 >>> Author: Jamie Gritton <jamie@FreeBSD.org> >>> AuthorDate: 2025-09-09 18:13:11 +0000 >>> Commit: Jamie Gritton <jamie@FreeBSD.org> >>> CommitDate: 2025-09-09 18:13:11 +0000 >>> jaildesc: replace EBADF with EINVAL >>> Following fd9e09cb, EBADF is not the suitable error code for a = non- >>> jail descriptor passed to jail_set, jail_get, jail_attach_fd, and >>> jail_remove_fd. >>> Reported by: kib >> Will you be MFC=E2=80=99ing this fix, the error checking one and any = future >> fixes to the new jaildesc code? The original jaildesc commit made it = in >> in time for stable/15 so will be part of 15.0, so either important >> fixes need to be MFC=E2=80=99ed to ensure we release something = without bugs or >> it should be reverted in stable/15 and the whole series later = MFC=E2=80=99ed >> once deemed ready. Especially given the discussion about file object >> ownership I=E2=80=99m a bit concerned that we have something in = stable/15 that >> has a design, rather than implementation, aspect that might be wrong, >> and we really don=E2=80=99t want to be shipping a broken syscall ABI = if so. >> Jessica >=20 > Yes, I just forgot to set the MFC tag in the commit. This and some > following commits are all slated for MFC. >=20 > This will include the file permission API concerns, and the missing > jail descriptor kevent support. Those are coming soon (next few days) > but I'm pushing the low-hanging fruit out right now. Great, thank you for the quick confirmation that it was just that, as I hoped, and that the bigger items are being worked on. Jessica
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D83F304A-6226-4877-88D9-EADC628C3CE9>