Date: Sat, 25 Dec 2021 11:25:34 -0800 From: Mark Millard via dev-commits-src-main <dev-commits-src-main@freebsd.org> To: unkadoug@gmail.com Cc: "madpilot@freebsd.org" <madpilot@FreeBSD.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 184c63db3c94 - main - Fix clerical error in page alloc Message-ID: <5EEFD155-6DF5-4865-AB16-C543FF7ADC6C@yahoo.com> References: <5EEFD155-6DF5-4865-AB16-C543FF7ADC6C.ref@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
From: Doug Moore <unkadoug_at_gmail.com> wrote oo
Date: Sat, 25 Dec 2021 11:56:10 -0600 :
Guido -
> I've made three vm changes this month, though it's taken me 6 commits =
to
> do it.
>=20
> The first change was trivial.
>=20
> The last commit before the second change was
> commit 02732f945ed2ec2b4fd03421923720608b28a615
> and that change was in place after
> commit f7aa44763d20d06c9ea5caf330aca02a8b107a70
>=20
> The last commit before the third change was
> commit b7ec0d268b73ce20c4f785d21cde9b174c91a553
That is an Alan Cox commit ("arm64: Introduce and
use pmap_pte_exists()") after one of yours,
fb38b29b5609b0c0769b2b2e1d6c917c0799f2a0
("vm_page: Remove extra test, dup code from page alloc")
(38 hours ago)
> and it was done after
> commit 0d5fac287294490ac488d74e598e019334610bdb
> (except for moving a comment).
That is one of yours ("vm: alloc pages from reserv before
breaking it"), 24 hours ago.
> I suggest you test before and after the second change to see if it
> introduced a problem, then before and after the third change.
I'll also note that:
=
https://lists.freebsd.org/archives/dev-commits-src-main/2021-December/0024=
37.html
claims to have seen problems before:
0d5fac287294490ac488d74e598e019334610bdb (vm: alloc pages from reserv=20
before breaking it)
and was hoping that progressing to that one would be a fix.
=3D=3D=3D
Mark Millard
marklmi at yahoo.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5EEFD155-6DF5-4865-AB16-C543FF7ADC6C>