Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Nov 2017 19:48:55 -0600
From:      Benjamin Kaduk <bjkfbsd@gmail.com>
To:        Alan Somers <asomers@freebsd.org>
Cc:        Ed Maste <emaste@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, src-committers <src-committers@freebsd.org>
Subject:   Re: svn commit: r326039 - in head: etc/mtree usr.bin/head usr.bin/head/tests
Message-ID:  <CAJ5_RoBVigmMGWzucCQEcqMr_2q92xkPkUBtxBsb0KjgsJUisA@mail.gmail.com>
In-Reply-To: <CAOtMX2iot8LRW1VqN5UNAaF4p59hdMwN7NJVRqXwbk5mm1f8-g@mail.gmail.com>
References:  <201711202255.vAKMt2nP014201@repo.freebsd.org> <CAPyFy2BDB5dVF_hURt9Xs4U4PzHW8KoL=6%2BEf0WGJgTxQSVaPw@mail.gmail.com> <CAOtMX2iot8LRW1VqN5UNAaF4p59hdMwN7NJVRqXwbk5mm1f8-g@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Nov 20, 2017 at 7:36 PM, Alan Somers <asomers@freebsd.org> wrote:
>
>
> Are there any automated tools that care about the "Differential
> Revision" field?  If so, they should be able to tell the difference
> between GitHub revisions and Phabricator revisions based on the URL.
>


Yes, Phabricator itself uses the link to close out the review.



> Using "Differential Revision" instead of "Pull request" is handy,
> because it's part of the standard commit template, which encourages
> consistency.
>

As Warner says, we could just add a new thing to the template instead
of overloading an existing one for convenience.

-Ben



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ5_RoBVigmMGWzucCQEcqMr_2q92xkPkUBtxBsb0KjgsJUisA>