Date: Wed, 2 Jul 2025 16:40:14 GMT From: Brooks Davis <brooks@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 1b06e0b889f8 - main - Revert "src/Makefile: log real/user/system time for build targets" Message-ID: <202507021640.562GeEsW055973@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by brooks: URL: https://cgit.FreeBSD.org/src/commit/?id=1b06e0b889f82046bd2ed6acb54fed00313b0b90 commit 1b06e0b889f82046bd2ed6acb54fed00313b0b90 Author: Brooks Davis <brooks@FreeBSD.org> AuthorDate: 2025-07-02 16:39:26 +0000 Commit: Brooks Davis <brooks@FreeBSD.org> CommitDate: 2025-07-02 16:39:26 +0000 Revert "src/Makefile: log real/user/system time for build targets" This broke `make makeman` by unconditionally adding output to all top level targets. Lacking an obvious and trivial workaround, it makes sense to back it out and rethink. This reverts commit afa70490ee779646fa0e936801cb28795580bf01. PR: 287274 Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D51119 --- Makefile | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/Makefile b/Makefile index d600eb69ed4b..4afec2a80c60 100644 --- a/Makefile +++ b/Makefile @@ -376,22 +376,13 @@ buildworld: upgrade_checks kernel-toolchain: upgrade_checks .endif -# we need the system time(1) command, not from the shell -time_cmd= /usr/bin/time - -# mktemp(1) is not portable -mktemp_cmd= mktemp /tmp/_time-logging-XXXXXXXXX - # # Handle the user-driven targets, using the source relative mk files. # tinderbox toolchains kernel-toolchains: .MAKE ${TGTS}: .PHONY .MAKE - ${_+_}@cd ${.CURDIR}; _time_tmp=$$(${mktemp_cmd}); \ - ${time_cmd} -o $${_time_tmp} -p env ${_MAKE} ${.TARGET}; \ - echo ">>> Time spent on target ${.TARGET}: $$(tr '\n' ' ' < $${_time_tmp})"; \ - rm -f $${_time_tmp} + ${_+_}@cd ${.CURDIR}; ${_MAKE} ${.TARGET} # The historic default "all" target creates files which may cause stale # or (in the cross build case) unlinkable results. Fail with an error
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202507021640.562GeEsW055973>