Date: Tue, 10 Mar 1998 09:12:32 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Michael Hancock <michaelh@cet.co.jp> Cc: Dmitrij Tejblum <dima@tejblum.dnttm.rssi.ru>, Terry Lambert <tlambert@primenet.com>, current@FreeBSD.ORG Subject: Re: vnode_pager: *** WARNING *** stale FS code in system Message-ID: <432.889517552@critter.freebsd.dk> In-Reply-To: Your message of "Tue, 10 Mar 1998 11:35:19 %2B0900." <Pine.SV4.3.95.980310111738.28539A-100000@parkplace.cet.co.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <Pine.SV4.3.95.980310111738.28539A-100000@parkplace.cet.co.jp>, Mich ael Hancock writes: >I think vnode_pager_generic_(put|get)pages should be moved to >vfs_default.c and renamed vop_std(put|get)pages. It would need to be >modified to accept ap instead of 4 components of ap. I agree. >Terry is trying to make it more visible to fs implementors so that they >take the time to understand how to make VM friendly implementations. The >"XXX - wimp out ..." comment is also added for extra emphasis. This >comment should be taken out and replaced by a comment explaining what a VM >friendly (get|put)pages should do. I agree. >I think vfs_default.c is visible enough. If you don't know it is there, you will never get though any kind of VFS work anyway. >This is a form discussion, the substance is the same. My personal opinion >is that it doesn't belong vnode_pager.c because it will tend to be ignored >by fs implementors. It most certainly doesn't belong there. -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." "Drink MONO-tonic, it goes down but it will NEVER come back up!" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?432.889517552>