Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 19 Nov 2019 02:00:13 +0000 (UTC)
From:      Justin Hibbits <jhibbits@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r354839 - head/sys/powerpc/aim
Message-ID:  <201911190200.xAJ20D0V010507@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: jhibbits
Date: Tue Nov 19 02:00:13 2019
New Revision: 354839
URL: https://svnweb.freebsd.org/changeset/base/354839

Log:
  powerpc/pmap: Remove an unused error from moea64_pvo_enter()
  
  ENOENT is leftover from mmu_oea.c's moea_pvo_enter(), where it's used to
  syncicache() on the first new mapping of a page.  This sync is done
  differently in OEA64.

Modified:
  head/sys/powerpc/aim/mmu_oea64.c

Modified: head/sys/powerpc/aim/mmu_oea64.c
==============================================================================
--- head/sys/powerpc/aim/mmu_oea64.c	Tue Nov 19 01:28:06 2019	(r354838)
+++ head/sys/powerpc/aim/mmu_oea64.c	Tue Nov 19 02:00:13 2019	(r354839)
@@ -1877,7 +1877,7 @@ moea64_kenter_attr(mmu_t mmu, vm_offset_t va, vm_paddr
 		free_pvo_entry(oldpvo);
 	}
 
-	if (error != 0 && error != ENOENT)
+	if (error != 0)
 		panic("moea64_kenter: failed to enter va %#zx pa %#jx: %d", va,
 		    (uintmax_t)pa, error);
 }
@@ -2515,8 +2515,8 @@ static int
 moea64_pvo_enter(mmu_t mmu, struct pvo_entry *pvo, struct pvo_head *pvo_head,
     struct pvo_entry **oldpvop)
 {
-	int first, err;
 	struct pvo_entry *old_pvo;
+	int err;
 
 	PMAP_LOCK_ASSERT(pvo->pvo_pmap, MA_OWNED);
 
@@ -2533,13 +2533,7 @@ moea64_pvo_enter(mmu_t mmu, struct pvo_entry *pvo, str
 		return (EEXIST);
 	}
 
-	/*
-	 * Remember if the list was empty and therefore will be the first
-	 * item.
-	 */
 	if (pvo_head != NULL) {
-		if (LIST_FIRST(pvo_head) == NULL)
-			first = 1;
 		LIST_INSERT_HEAD(pvo_head, pvo, pvo_vlink);
 	}
 
@@ -2570,7 +2564,7 @@ moea64_pvo_enter(mmu_t mmu, struct pvo_entry *pvo, str
 		    pvo->pvo_vaddr & PVO_LARGE);
 #endif
 
-	return (first ? ENOENT : 0);
+	return (0);
 }
 
 static void

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201911190200.xAJ20D0V010507>