Date: Tue, 14 Jul 2020 21:27:17 +0200 From: =?UTF-8?Q?Stefan_E=c3=9fer?= <se@freebsd.org> To: Adrian Chadd <adrian@FreeBSD.org> Cc: Brooks Davis <brooks@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Gavin Howard <gavin.d.howard@gmail.com> Subject: Re: svn commit: r363172 - head/contrib/bc/src Message-ID: <b168771a-7c26-66b9-217e-1c477c4ff34e@freebsd.org> In-Reply-To: <20200714173151.GB23830@spindle.one-eyed-alien.net> References: <202007140502.06E52IZn022859@repo.freebsd.org> <20200714173151.GB23830@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NOsHfQZeaBKuU6jKjefVS6MzFSzJAdCuP Content-Type: multipart/mixed; boundary="gI6u1mYaNUQhpNeA3r9xuBJWMRu7ZDL7G" --gI6u1mYaNUQhpNeA3r9xuBJWMRu7ZDL7G Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 14.07.20 um 19:31 schrieb Brooks Davis: > On Tue, Jul 14, 2020 at 05:02:18AM +0000, Adrian Chadd wrote: >> Author: adrian >> Date: Tue Jul 14 05:02:18 2020 >> New Revision: 363172 >> URL: https://svnweb.freebsd.org/changeset/base/363172 >> >> Log: >> [bc] Fix a "maybe uninitialized" compiler warning under mips-gcc-6.3= =2E0. >> =20 >> I guess this didn't like the case statements.. ? But this does quiet= en >> the compiler error. >=20 > IMO it would be better to disable this warning for this (old) compiler > on this file rather than making a change here (in general we should be > removing these sorts of changes). That being said, we need to write > down some guidance on this so we have a clear set of principles and we > can figure out how we decided which compilers are on which side of the > line. I fully agree and have notified the "upstream". He may want to apply the change, but I do not expect him to tag a new release for this minor change. Since this is contributed software, I'd really appreciate, if a solution was only applied to the local build tree of the person affected by this local problem - a generally applicable solution can then be discussed and applied, if found to be necessary. Regards, STefan --gI6u1mYaNUQhpNeA3r9xuBJWMRu7ZDL7G-- --NOsHfQZeaBKuU6jKjefVS6MzFSzJAdCuP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAl8OBxcACgkQR+u171r9 9URUXQgAu6xvrT9j9+FwU2a1aNR5fceYErs2YPUmra2dv2fWCyipAg+wlXxSLkON /fNieVxhmXIZl+M2qic/X9BM8Y/5mZplWzuZF6+PZsIPUU03eraArregUACF5Mld dBLR+1dyAw28fiZPoUzNhfnpDLw757gfHbk2iXL+MDseaVQfxKujw/b3EcX4s8Pi 5xx8hbSjcRzyNTolCmqFcYlV2zu9psF/7fAi32qk4CVb4Nqj6athhB/2ZRPmYBTn Gy4Ife/U6hEH1yFxzPX+gql499OH+Sh/2Cyx7ysomkvWdMPX/g7gKa7NsXvFTRi7 gmobX8mv+Aon0GH/Gv4YVeNVFXGotA== =MgVO -----END PGP SIGNATURE----- --NOsHfQZeaBKuU6jKjefVS6MzFSzJAdCuP--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b168771a-7c26-66b9-217e-1c477c4ff34e>