Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 02 Sep 2009 08:14:06 -0700
From:      Doug Barton <dougb@FreeBSD.org>
To:        remko@elvandar.org
Cc:        svn-src-stable@freebsd.org, svn-src-all@freebsd.org, Alfred Perlstein <alfred@FreeBSD.org>, src-committers@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   Re: svn commit: r196746 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/usb  dev/usb/input dev/xen/xenpci
Message-ID:  <4A9E8BBE.9060000@FreeBSD.org>
In-Reply-To: <8497dc1520e5fe6b2b3727d5fb92f358.squirrel@www.jr-hosting.nl>
References:  <200909020212.n822C7Il078379@svn.freebsd.org> <8497dc1520e5fe6b2b3727d5fb92f358.squirrel@www.jr-hosting.nl>

next in thread | previous in thread | raw e-mail | index | archive | help
Remko Lodder wrote:
> On Wed, September 2, 2009 4:12 am, Alfred Perlstein wrote:
>> Author: alfred
>> Date: Wed Sep  2 02:12:07 2009
>> New Revision: 196746
>> URL: http://svn.freebsd.org/changeset/base/196746
>>
>> Log:
>>   MFC: r196489,196498
>>   Critical USB bugfixes for 8.0
>>
> 
> Dear Alfred (and hps!),
> 
> It would be awesome to see something more about this in the commit log. I
> needed to look up the specific revisions to see what changed. I always
> learned from Warner and people, that including the original commit
> message(s) saves a lot of time and makes it clear about what is being
> merged.

... and I was taught that including the complete commit message is a
waste of space since it already exists in HEAD, and therefore to
summarize the changes briefly rather than reporting them verbatim. A
philosophy with which I agree. :)  There were only 2 changes merged,
going back and looking at the logs for them could not have been that
much of a burden.

That said, for RELENG_8 commits during the freeze re@ did ask in one
of their many messages about commit approvals to paste the complete
commit message in the MFC. So, bad Alfred, no cookie. :)


Doug

-- 

    This .signature sanitized for your protection




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A9E8BBE.9060000>