Date: Wed, 2 May 2012 10:48:05 +0200 From: Guido Falsi <madpilot@FreeBSD.org> To: nemysis <nemysis@gmx.ch> Cc: cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, Chris Rees <crees@FreeBSD.org>, Thomas Abthorpe <tabthorpe@FreeBSD.org>, cvs-ports@FreeBSD.org Subject: Re: cvs commit: ports/graphics Makefile ports/graphics/viewnior Makefile distinfo pkg-descr pkg-plist ports/graphics/viewnior/files patch-po_Makefile.in.in Message-ID: <20120502084805.GA83818@megatron.madpilot.net> In-Reply-To: <20120501234357.792c2599@nemysis3now.no-ip.biz> References: <201204301752.q3UHquWJ034347@repoman.freebsd.org> <20120501204522.GA23385@server.vk2pj.dyndns.org> <20120501234357.792c2599@nemysis3now.no-ip.biz>
next in thread | previous in thread | raw e-mail | index | archive | help
--d6Gm4EdcadzBjdND Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 01, 2012 at 11:43:57PM +0200, nemysis wrote: > On Wed, 2 May 2012 06:45:22 +1000 > Peter Jeremy <peterjeremy@acm.org> wrote: > > > On 2012-Apr-30 17:52:56 +0000, Guido Falsi <madpilot@FreeBSD.org> wrote: > > > This is Viewnior, an image viewer program. Created to be simple, fast > > > and elegant. It's minimalistic interface provides more screenspace for > > > your images. Among its features are: > > > > This looks interesting, thanks. > > > > I notice that NLS is a configure-time option but USE_GETTEXT is > > unconditionally set (as well as being set within the !WITHOUT_NLS > > condtiional block). I presume this is a cut-and-paste error. > > > > > I have seen that in FreeBSD Ports collection is older version as you have > give me and i have adjusted. > > diff -ruN viewnior.old viewnior > viewnior.diff > > Should I this send to freebsd-ports-bugs@freebsd.org I see that the problem is caused by USE_GETTEXT being defined both unconditionally and in the option check. Sorry, this is my fault. If you approve I'd commit the attached simple fix. -- Guido Falsi <madpilot@FreeBSD.org> --d6Gm4EdcadzBjdND Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="viewnior.diff" Index: Makefile =================================================================== RCS file: /home/ncvs/ports/graphics/viewnior/Makefile,v retrieving revision 1.1 diff -u -r1.1 Makefile --- Makefile 30 Apr 2012 17:52:55 -0000 1.1 +++ Makefile 2 May 2012 08:44:54 -0000 @@ -20,7 +20,6 @@ GNU_CONFIGURE= yes USE_AUTOTOOLS= autoconf -USE_GETTEXT= yes USE_GMAKE= yes USE_GNOME= glib20 gtk20 intltool pkgconfig INSTALLS_ICONS= yes --d6Gm4EdcadzBjdND--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120502084805.GA83818>