Date: Fri, 17 Jan 2003 05:00:16 -0800 (PST) From: Lukas Ertl <l.ertl@univie.ac.at> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/47149: make -C documented but not working - [PATCH] Message-ID: <200301171300.h0HD0GKG043688@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/47149; it has been noted by GNATS. From: Lukas Ertl <l.ertl@univie.ac.at> To: freebsd-gnats-submit@FreeBSD.org Cc: uk@univie.ac.at Subject: Re: bin/47149: make -C documented but not working - [PATCH] Date: Fri, 17 Jan 2003 13:50:37 +0100 (CET) This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-611245315-1042807837=:18530 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE The problem of "make -C" on 4-STABLE is just a missing char in the OPTFLAGS string (this must have happened when MFC'ing the -C option). The problem of "make -C" on both 4-STABLE _and_ 5-CURRENT is that it simply doesn't work correctly, because the current program flow of "make" sets the essential .CURDIR and .OBJDIR Makefile vars _before_ chdir()'ing to the directory given as -C parameter. The attached patch is just moving around some code, but it seems to correct the problem. I don't have enough knowledge of the make internals to be sure that it doesn't have any nasty side effects, so please review it closely. best regards, le --=20 Lukas Ertl eMail: l.ertl@univie.ac.at UNIX-Systemadministrator Tel.: (+43 1) 4277-14073 Zentraler Informatikdienst (ZID) Fax.: (+43 1) 4277-9140 der Universit=E4t Wien http://mailbox.univie.ac.at/~le/ --0-611245315-1042807837=:18530 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="make.patch" Content-Transfer-Encoding: BASE64 Content-ID: <20030117135037.R18530@pcle2.cc.univie.ac.at> Content-Description: Content-Disposition: attachment; filename="make.patch" LS0tIHNyYy91c3IuYmluL21ha2UvbWFpbi5jCUZyaSBKYW4gMTcgMTM6MzA6 MzAgMjAwMw0KKysrIHNyYy91c3IuYmluL21ha2UvbWFpbi5jLm5ldwlGcmkg SmFuIDE3IDEzOjM5OjU3IDIwMDMNCkBAIC00ODQsMTcgKzQ4NCw2IEBADQog CQl9DQogCX0NCiAjZW5kaWYNCi0JLyoNCi0JICogRmluZCB3aGVyZSB3ZSBh cmUuLi4NCi0JICogQWxsIHRoaXMgY29kZSBpcyBzbyB0aGF0IHdlIGtub3cg d2hlcmUgd2UgYXJlIHdoZW4gd2Ugc3RhcnQgdXANCi0JICogb24gYSBkaWZm ZXJlbnQgbWFjaGluZSB3aXRoIHBtYWtlLg0KLQkgKi8NCi0JY3VyZGlyID0g Y2RwYXRoOw0KLQlpZiAoZ2V0Y3dkKGN1cmRpciwgTUFYUEFUSExFTikgPT0g TlVMTCkNCi0JCWVycigyLCBOVUxMKTsNCi0NCi0JaWYgKHN0YXQoY3VyZGly LCAmc2EpID09IC0xKQ0KLQkgICAgZXJyKDIsICIlcyIsIGN1cmRpcik7DQog DQogI2lmIGRlZmluZWQoX19pMzg2X18pICYmIGRlZmluZWQoX19GcmVlQlNE X3ZlcnNpb24pICYmIFwNCiAgICAgX19GcmVlQlNEX3ZlcnNpb24gPiAzMDAw MDMNCkBAIC01NjAsNDggKzU0OSw2IEBADQogCQkJbWFjaGluZV9jcHUgPSAi dW5rbm93biI7DQogCX0NCiAJDQotCS8qDQotCSAqIFRoZSBvYmplY3QgZGly ZWN0b3J5IGxvY2F0aW9uIGlzIGRldGVybWluZWQgdXNpbmcgdGhlDQotCSAq IGZvbGxvd2luZyBvcmRlciBvZiBwcmVmZXJlbmNlOg0KLQkgKg0KLQkgKgkx LiBNQUtFT0JKRElSUFJFRklYYGN3ZGANCi0JICoJMi4gTUFLRU9CSkRJUg0K LQkgKgkzLiBfUEFUSF9PQkpESVIuJHtNQUNISU5FfQ0KLQkgKgk0LiBfUEFU SF9PQkpESVINCi0JICoJNS4gX1BBVEhfT0JKRElSUFJFRklYYGN3ZGANCi0J ICoNCi0JICogSWYgb25lIG9mIHRoZSBmaXJzdCB0d28gZmFpbHMsIHVzZSB0 aGUgY3VycmVudCBkaXJlY3RvcnkuDQotCSAqIElmIHRoZSByZW1haW5pbmcg dGhyZWUgYWxsIGZhaWwsIHVzZSB0aGUgY3VycmVudCBkaXJlY3RvcnkuDQot CSAqDQotCSAqIE9uY2UgdGhpbmdzIGFyZSBpbml0dGVkLA0KLQkgKiBoYXZl IHRvIGFkZCB0aGUgb3JpZ2luYWwgZGlyZWN0b3J5IHRvIHRoZSBzZWFyY2gg cGF0aCwNCi0JICogYW5kIG1vZGlmeSB0aGUgcGF0aHMgZm9yIHRoZSBNYWtl ZmlsZXMgYXByb3ByaWF0ZWx5LiAgVGhlDQotCSAqIGN1cnJlbnQgZGlyZWN0 b3J5IGlzIGFsc28gcGxhY2VkIGFzIGEgdmFyaWFibGUgZm9yIG1ha2Ugc2Ny aXB0cy4NCi0JICovDQotCWlmICghKHBhdGhwID0gZ2V0ZW52KCJNQUtFT0JK RElSUFJFRklYIikpKSB7DQotCQlpZiAoIShwYXRoID0gZ2V0ZW52KCJNQUtF T0JKRElSIikpKSB7DQotCQkJcGF0aCA9IF9QQVRIX09CSkRJUjsNCi0JCQlw YXRocCA9IF9QQVRIX09CSkRJUlBSRUZJWDsNCi0JCQkodm9pZCkgc25wcmlu dGYobWRwYXRoLCBNQVhQQVRITEVOLCAiJXMuJXMiLA0KLQkJCQkJcGF0aCwg bWFjaGluZSk7DQotCQkJaWYgKCEob2JqZGlyID0gY2hkaXJfdmVyaWZ5X3Bh dGgobWRwYXRoLCBvYnBhdGgpKSkNCi0JCQkJaWYgKCEob2JqZGlyPWNoZGly X3ZlcmlmeV9wYXRoKHBhdGgsIG9icGF0aCkpKSB7DQotCQkJCQkodm9pZCkg c25wcmludGYobWRwYXRoLCBNQVhQQVRITEVOLA0KLQkJCQkJCQkiJXMlcyIs IHBhdGhwLCBjdXJkaXIpOw0KLQkJCQkJaWYgKCEob2JqZGlyPWNoZGlyX3Zl cmlmeV9wYXRoKG1kcGF0aCwNCi0JCQkJCQkJCSAgICAgICBvYnBhdGgpKSkN Ci0JCQkJCQlvYmpkaXIgPSBjdXJkaXI7DQotCQkJCX0NCi0JCX0NCi0JCWVs c2UgaWYgKCEob2JqZGlyID0gY2hkaXJfdmVyaWZ5X3BhdGgocGF0aCwgb2Jw YXRoKSkpDQotCQkJb2JqZGlyID0gY3VyZGlyOw0KLQl9DQotCWVsc2Ugew0K LQkJKHZvaWQpIHNucHJpbnRmKG1kcGF0aCwgTUFYUEFUSExFTiwgIiVzJXMi LCBwYXRocCwgY3VyZGlyKTsNCi0JCWlmICghKG9iamRpciA9IGNoZGlyX3Zl cmlmeV9wYXRoKG1kcGF0aCwgb2JwYXRoKSkpDQotCQkJb2JqZGlyID0gY3Vy ZGlyOw0KLQl9DQotDQogCWNyZWF0ZSA9IExzdF9Jbml0KEZBTFNFKTsNCiAJ bWFrZWZpbGVzID0gTHN0X0luaXQoRkFMU0UpOw0KIAllbnZGaXJzdFZhcnMg PSBMc3RfSW5pdChGQUxTRSk7DQpAQCAtNjI4LDcgKzU3NSw2IEBADQogCWZv cmNlSm9icyA9IEZBTFNFOyAgICAgICAgICAgICAgLyogTm8gLWogZmxhZyAq Lw0KIAljb21wYXRNYWtlID0gRkFMU0U7CQkvKiBObyBjb21wYXQgbW9kZSAq Lw0KIA0KLQ0KIAkvKg0KIAkgKiBJbml0aWFsaXplIHRoZSBwYXJzaW5nLCBk aXJlY3RvcnkgYW5kIHZhcmlhYmxlIG1vZHVsZXMgdG8gcHJlcGFyZQ0KIAkg KiBmb3IgdGhlIHJlYWRpbmcgb2YgaW5jbHVzaW9uIHBhdGhzIGFuZCB2YXJp YWJsZSBzZXR0aW5ncyBvbiB0aGUNCkBAIC02NDEsMTAgKzU4Nyw2IEBADQog CVZhcl9Jbml0KCk7CQkvKiBBcyB3ZWxsIGFzIHRoZSBsaXN0cyBvZiB2YXJp YWJsZXMgZm9yDQogCQkJCSAqIHBhcnNpbmcgYXJndW1lbnRzICovDQogICAg ICAgICBzdHJfaW5pdCgpOw0KLQlpZiAob2JqZGlyICE9IGN1cmRpcikNCi0J CURpcl9BZGREaXIoZGlyU2VhcmNoUGF0aCwgY3VyZGlyKTsNCi0JVmFyX1Nl dCgiLkNVUkRJUiIsIGN1cmRpciwgVkFSX0dMT0JBTCk7DQotCVZhcl9TZXQo Ii5PQkpESVIiLCBvYmpkaXIsIFZBUl9HTE9CQUwpOw0KIA0KIAkvKg0KIAkg KiBJbml0aWFsaXplIHZhcmlvdXMgdmFyaWFibGVzLg0KQEAgLTY3NCw2ICs2 MTYsNjUgQEANCiAjZW5kaWYNCiANCiAJTWFpblBhcnNlQXJncyhhcmdjLCBh cmd2KTsNCisNCisJLyoNCisJICogRmluZCB3aGVyZSB3ZSBhcmUuLi4NCisJ ICogQWxsIHRoaXMgY29kZSBpcyBzbyB0aGF0IHdlIGtub3cgd2hlcmUgd2Ug YXJlIHdoZW4gd2Ugc3RhcnQgdXANCisJICogb24gYSBkaWZmZXJlbnQgbWFj aGluZSB3aXRoIHBtYWtlLg0KKwkgKi8NCisJY3VyZGlyID0gY2RwYXRoOw0K KwlpZiAoZ2V0Y3dkKGN1cmRpciwgTUFYUEFUSExFTikgPT0gTlVMTCkNCisJ CWVycigyLCBOVUxMKTsNCisNCisJaWYgKHN0YXQoY3VyZGlyLCAmc2EpID09 IC0xKQ0KKwkgICAgZXJyKDIsICIlcyIsIGN1cmRpcik7DQorDQorCS8qDQor CSAqIFRoZSBvYmplY3QgZGlyZWN0b3J5IGxvY2F0aW9uIGlzIGRldGVybWlu ZWQgdXNpbmcgdGhlDQorCSAqIGZvbGxvd2luZyBvcmRlciBvZiBwcmVmZXJl bmNlOg0KKwkgKg0KKwkgKgkxLiBNQUtFT0JKRElSUFJFRklYYGN3ZGANCisJ ICoJMi4gTUFLRU9CSkRJUg0KKwkgKgkzLiBfUEFUSF9PQkpESVIuJHtNQUNI SU5FfQ0KKwkgKgk0LiBfUEFUSF9PQkpESVINCisJICoJNS4gX1BBVEhfT0JK RElSUFJFRklYYGN3ZGANCisJICoNCisJICogSWYgb25lIG9mIHRoZSBmaXJz dCB0d28gZmFpbHMsIHVzZSB0aGUgY3VycmVudCBkaXJlY3RvcnkuDQorCSAq IElmIHRoZSByZW1haW5pbmcgdGhyZWUgYWxsIGZhaWwsIHVzZSB0aGUgY3Vy cmVudCBkaXJlY3RvcnkuDQorCSAqDQorCSAqIE9uY2UgdGhpbmdzIGFyZSBp bml0dGVkLA0KKwkgKiBoYXZlIHRvIGFkZCB0aGUgb3JpZ2luYWwgZGlyZWN0 b3J5IHRvIHRoZSBzZWFyY2ggcGF0aCwNCisJICogYW5kIG1vZGlmeSB0aGUg cGF0aHMgZm9yIHRoZSBNYWtlZmlsZXMgYXByb3ByaWF0ZWx5LiAgVGhlDQor CSAqIGN1cnJlbnQgZGlyZWN0b3J5IGlzIGFsc28gcGxhY2VkIGFzIGEgdmFy aWFibGUgZm9yIG1ha2Ugc2NyaXB0cy4NCisJICovDQorCWlmICghKHBhdGhw ID0gZ2V0ZW52KCJNQUtFT0JKRElSUFJFRklYIikpKSB7DQorCQlpZiAoIShw YXRoID0gZ2V0ZW52KCJNQUtFT0JKRElSIikpKSB7DQorCQkJcGF0aCA9IF9Q QVRIX09CSkRJUjsNCisJCQlwYXRocCA9IF9QQVRIX09CSkRJUlBSRUZJWDsN CisJCQkodm9pZCkgc25wcmludGYobWRwYXRoLCBNQVhQQVRITEVOLCAiJXMu JXMiLA0KKwkJCQkJcGF0aCwgbWFjaGluZSk7DQorCQkJaWYgKCEob2JqZGly ID0gY2hkaXJfdmVyaWZ5X3BhdGgobWRwYXRoLCBvYnBhdGgpKSkNCisJCQkJ aWYgKCEob2JqZGlyPWNoZGlyX3ZlcmlmeV9wYXRoKHBhdGgsIG9icGF0aCkp KSB7DQorCQkJCQkodm9pZCkgc25wcmludGYobWRwYXRoLCBNQVhQQVRITEVO LA0KKwkJCQkJCQkiJXMlcyIsIHBhdGhwLCBjdXJkaXIpOw0KKwkJCQkJaWYg KCEob2JqZGlyPWNoZGlyX3ZlcmlmeV9wYXRoKG1kcGF0aCwNCisJCQkJCQkJ CSAgICAgICBvYnBhdGgpKSkNCisJCQkJCQlvYmpkaXIgPSBjdXJkaXI7DQor CQkJCX0NCisJCX0NCisJCWVsc2UgaWYgKCEob2JqZGlyID0gY2hkaXJfdmVy aWZ5X3BhdGgocGF0aCwgb2JwYXRoKSkpDQorCQkJb2JqZGlyID0gY3VyZGly Ow0KKwl9DQorCWVsc2Ugew0KKwkJKHZvaWQpIHNucHJpbnRmKG1kcGF0aCwg TUFYUEFUSExFTiwgIiVzJXMiLCBwYXRocCwgY3VyZGlyKTsNCisJCWlmICgh KG9iamRpciA9IGNoZGlyX3ZlcmlmeV9wYXRoKG1kcGF0aCwgb2JwYXRoKSkp DQorCQkJb2JqZGlyID0gY3VyZGlyOw0KKwl9DQorDQorCWlmIChvYmpkaXIg IT0gY3VyZGlyKQ0KKwkJRGlyX0FkZERpcihkaXJTZWFyY2hQYXRoLCBjdXJk aXIpOw0KKwlWYXJfU2V0KCIuQ1VSRElSIiwgY3VyZGlyLCBWQVJfR0xPQkFM KTsNCisJVmFyX1NldCgiLk9CSkRJUiIsIG9iamRpciwgVkFSX0dMT0JBTCk7 DQogDQogCS8qDQogCSAqIEJlIGNvbXBhdGlibGUgaWYgdXNlciBkaWQgbm90 IHNwZWNpZnkgLWogYW5kIGRpZCBub3QgZXhwbGljaXRseQ0K --0-611245315-1042807837=:18530-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301171300.h0HD0GKG043688>