Date: Mon, 17 Oct 2016 22:03:04 -0700 From: Marcel Moolenaar <marcel@xcllnt.net> To: Ngie Cooper <yaneurabeya@gmail.com>, Marcel Moolenaar <marcel@freebsd.org> Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r307544 - head/usr.bin/mkimg Message-ID: <etPan.5805ad08.3d249f8a.6e8c@xcllnt.net> In-Reply-To: <E68F92C8-DF7D-440E-A6B9-E090EEE38785@gmail.com> References: <201610180155.u9I1t79S037286@repo.freebsd.org> <E68F92C8-DF7D-440E-A6B9-E090EEE38785@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On October 17, 2016 at 8:34:11 PM, Ngie Cooper (yaneurabeya@gmail.com) wrote:
> On Oct 17, 2016, at 18:55, Marcel Moolenaar <marcel@FreeBSD.org> wrote:
>
*snip*
> +CFLAGS+=-I${SRCTOP}/sys/sys/disk
Isn't it a better app idea to maintain the disk/ namespace for includes?
Thanks!
You mean, add -I${SRCTOP}//sys/sys on the compile line and change the code to use #include <disk/foo.h>?
Unfortunately, that creates conflicts with header files that are included as <stdfoo.h> and match headers we have under sys/sys.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQIcBAEBCgAGBQJYBa0IAAoJEIda8t8f0tjjl2AP/3NaWuvqH10XP/DrbOLimUP5
f9qbjU42j0KkyUHAg2lDSneufGD9HQXrDmdzaMbBU9McYJcLIJU2WICB7EoFP/gS
/0C2fZAIDFZ1sw3oEKUVeyx8Vyv9hoJy+c0rk/ijhTVKlOCkT+hlVjeF8jo4y9KB
z7X/ustX+gjM7OuPadPlzR84Isqw57mfd5kjbytJ/clxCGaZSJwbLbY0uhZbC8w1
/6aQQsLD5QEYj0minJEkCYhhl1WGXS76BJJYfMeS0FtnY2L6oc3RKgAgxWxkwmRB
qJWLBmTZ4LnNElsejGXl8+t8X9+f1YNzL4mCWMhRdcD6SH4vQIPuqa6akQTTsbdj
zHp7QpMn2/XYfmuuVrspzuQq1JNLkKb7VplcvSFO5aMhe3VvGL/w0TwS1hNJvMFM
/g3JKwAkH/V+cdOGC1d4deVTdiG8HzDYPy5K5mFcylT62oV4B6UvurcNy4QQ0tN7
rLMCJJiTwlJbWxcBxePU6uuoA4LsuoEuI9FbYfg8lQteSuUBr6EN/flgjXKT5lTT
9pXoLso2L4n9YtN/5Ea1PDf1NaPZf9LtTweUczwU1MYI9srrmfH/0eDCrS4faLrp
txoGllJPCXITMcrsmgZZb9z6lmcqZs26mriTyBK7aJ/RZZnksMcOwaN83dTsDVh2
ItSJjc+sN77mlCnXipED
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?etPan.5805ad08.3d249f8a.6e8c>