Date: Thu, 14 Feb 2002 10:54:35 -0600 From: Jonathan Lemon <jlemon@flugsvamp.com> To: David Malone <dwmalone@maths.tcd.ie> Cc: ru@FreeBSD.org, freebsd-bugs@FreeBSD.org, jlemon@FreeBSD.org, Alan Judge <Alan.Judge@eircom.net>, kurnik@kurnik.pl, mark@lomag.net Subject: Re: kern/34658: syncache related panic (2nd panic from softdep) Message-ID: <20020214105435.B14437@prism.flugsvamp.com> In-Reply-To: <20020214143431.GA52859@boole.maths.tcd.ie> References: <200202141329.g1EDTOJ89729@freefall.freebsd.org> <20020214143431.GA52859@boole.maths.tcd.ie>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 14, 2002 at 02:34:31PM +0000, David Malone wrote:
> On Thu, Feb 14, 2002 at 05:29:24AM -0800, ru@FreeBSD.org wrote:
> > Jonathan, could this be related to a problem fixed in tcp_syncache.c,v 1.11?
>
> Jonathan asked Alan to test the following patch, and I think that
> the problem went away.
>
Attached is a more robust version of the same patch.
Please test, as I'm not able to at the moment. Disabling syncookies
should also work around this problem.
--
Jonathan
Index: tcp_syncache.c
===================================================================
RCS file: /ncvs/src/sys/netinet/tcp_syncache.c,v
retrieving revision 1.10
diff -u -r1.10 tcp_syncache.c
--- tcp_syncache.c 2002/02/07 20:58:45 1.10
+++ tcp_syncache.c 2002/02/14 16:57:21
@@ -666,7 +666,7 @@
tp->rcv_wnd = sc->sc_wnd;
tp->rcv_adv += tp->rcv_wnd;
- tp->t_flags = sc->sc_tp->t_flags & (TF_NOPUSH|TF_NODELAY);
+ tp->t_flags = sototcpcb(lso)->t_flags & (TF_NOPUSH|TF_NODELAY);
if (sc->sc_flags & SCF_NOOPT)
tp->t_flags |= TF_NOOPT;
if (sc->sc_flags & SCF_WINSCALE) {
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020214105435.B14437>