Date: Fri, 9 Sep 1994 09:57:34 -0700 (PDT) From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com> To: paul@freefall.cdrom.com (Paul Richards) Cc: ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-libexec@freefall.cdrom.com, davidg@freefall.cdrom.com, dfr@freefall.cdrom.com, dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com, gpalmer@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, jkh@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, paul@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com Subject: Re: cvs commit: src/libexec Makefile Message-ID: <199409091657.JAA11625@gndrsh.aac.dev.com> In-Reply-To: <199409091640.JAA12132@freefall.cdrom.com> from "Paul Richards" at Sep 9, 94 09:40:29 am
next in thread | previous in thread | raw e-mail | index | archive | help
I am not picking on paul here, even I was guilty of it this last night
in my rush to get some things done... but we need to clean this act up,
the log files are getting cluttered to death, and no one is getting
reviews :-(.
> paul 94/09/09 09:40:29
^^^^^^
>
> Modified: libexec Makefile
> Log:
> Removed bugfiler.
> Submitted by: Paul Richards
^^^^^^^^^^^^
Reviewed by:
Submitted by:
CVS: ----------------------------------------------------------------------
CVS: Delete the ``Reviewed by'' line if this is somebody else's work
CVS: (you are the reviewer).
CVS: Delete the ``Submitted by'' line if this is NOT somebody else's
^^^^^^^^^^^^^^
CVS: work (you are the author).
^^^^^^^^^^^^^^^^^^^
And from /usr/src/CVS-INFO
This file really doesn't belong here, but I wanted to elicit comment
without starting a discussion as to where it really does belong.
Anyway, here goes...
When the new CVS tree was set up back in May, I wanted to ensure that
everybody at least gave some thought to asking other people to look at
code before it is committed. Since we have had a number of rancorous
discussions in the past about both committing code prematurely, and
committing code that was written by someone else, I decided to use the
`template' function of CVS to give people a chance to think about it.
The template looks like this:
Reviewed by:
Submitted by:
CVS: ----------------------------------------------------------------------
CVS: Delete the ``Reviewed by'' line if this is somebody else's work
CVS: (you are the reviewer).
CVS: Delete the ``Submitted by'' line if this is NOT somebody else's
CVS: work (you are the author).
If you are making substantial or possibly controversial changes to the
code, please talk to someone else who either has commit authority, or
who is recognized as an expert in the BSD community. This latter
category includes the author of the program or subsystem you're
modifying, like Rick Macklem for the NFS code, or Keith Bostic for
`vi'.
If the changes are insubstantial and noncontroversial (e.g., fixing
spelling errors, or most Makefile changes) there is no need for
review. Please delete the ``Reviewed by:'' line, though, so that the
logs look cleaner.
If you are committing code or modifications which were originally done
by some other person or group, them please please please make sure to
credit them in the ``Submitted by'' line. In this case, you are
considered to be the reviewer. If it is your own code, or that of
another team member, then you should delete the ``Submitted by'' line,
so that the logs look cleaner.
-GAWollman
--
Rod Grimes rgrimes@gndrsh.aac.dev.com
Accurate Automation Company Custom computers for FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199409091657.JAA11625>