Date: Mon, 05 Dec 2005 11:41:07 +0000 From: Florent Thoumie <flz@FreeBSD.org> To: obrien@FreeBSD.org Cc: cvs-ports@FreeBSD.org, Alexey Dokuchaev <danfe@FreeBSD.org>, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: cvs commit: ports/shells/bash Makefile Message-ID: <1133782867.879.3.camel@cream.xbsd.org> In-Reply-To: <20051205093626.GA68544@dragon.NUXI.org> References: <200511301510.jAUFACmr038837@repoman.freebsd.org> <20051130161657.GA65549@FreeBSD.org> <1133371126.1219.23.camel@cream.xbsd.org> <20051130183717.GA71920@xor.obsecurity.org> <1133380999.1219.30.camel@cream.xbsd.org> <20051205093626.GA68544@dragon.NUXI.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Le Lundi 05 décembre 2005 à 01:36 -0800, David O'Brien a écrit : > On Wed, Nov 30, 2005 at 08:03:19PM +0000, Florent Thoumie wrote: > > Le Mercredi 30 novembre 2005 à 13:37 -0500, Kris Kennaway a écrit : > > > On Wed, Nov 30, 2005 at 05:18:46PM +0000, Florent Thoumie wrote: > > > > Le Mercredi 30 novembre 2005 ?? 16:16 +0000, Alexey Dokuchaev a ??crit : > > > > > On Wed, Nov 30, 2005 at 03:10:12PM +0000, Florent Thoumie wrote: > > > > > > flz 2005-11-30 15:10:12 UTC > > > > > > > > > > > > FreeBSD ports repository > > > > > > > > > > > > Modified files: > > > > > > shells/bash Makefile > > > > > > Log: > > > > > > - Add WANT_STATIC_BASH knob. > > > > > > > > > > WANT_ prefix belongs to bpm's internal namespace; it should not be used > > > > > this way. > > > > > > > > Agreed, Pav made the same notice but : > > > > > > > > 1) that's not my port and, > > > > > > Don't commit bogus changes, and > > > > > > > 2) shells/bash2 has the same exact construction. > > > > > > fix bogus changes when you encounter them. > > > > I'll send a PR with s/WANT/WITH/ later and will commit the fix > > in two weeks with maintainer timeout. > > *sigh* why all the overhead? Since you're already in the middle of this > issue, please make it right for our users and just commit the fixed > version now. I'm fine with people fixing my mistakes, but that's not something I would assume for every maintainer, so I just wanted to ask in the first place. Anyway, thanks for answering, I'll commit it in a couple of minutes. -- Florent Thoumie flz@FreeBSD.org FreeBSD committer [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBDlCdTMxEkbVFH3PQRAgHHAJ0W8YmgO9nIldNUlSivDsKlO9Wd4gCaAh9x RFYA1HYwrUuFg36mSjuRSLA= =p5yN -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1133782867.879.3.camel>