Date: Sun, 5 Oct 2025 08:24:52 -0600 From: Warner Losh <imp@bsdimp.com> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: current@freebsd.org Subject: Re: svnlite code in Makefile.inc1 still needed? Message-ID: <CANCZdfpO4_4DS2gdfZX-oKuADi7M=ic4SjgpAgjX1iMBK82LFw@mail.gmail.com> In-Reply-To: <84s91nn3-5280-94p9-997s-q19931p3s7n1@yvfgf.mnoonqbm.arg> References: <91r7p6r9-5qos-31qo-64o0-p4r0q2p1opsr@mnoonqbm.arg> <CANCZdfrY_AtdOjXvi4LRbFbOHLv-QhBCe52zjUuH4qdLKPmdQw@mail.gmail.com> <84s91nn3-5280-94p9-997s-q19931p3s7n1@yvfgf.mnoonqbm.arg>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Oh! You have svnlite installed. Warner On Sun, Oct 5, 2025 at 2:10 AM Bjoern A. Zeeb < bzeeb-lists@lists.zabbadoz.net> wrote: > On Sat, 4 Oct 2025, Warner Losh wrote: > > > On Sat, Oct 4, 2025 at 2:37 PM Bjoern A. Zeeb < > > bzeeb-lists@lists.zabbadoz.net> wrote: > > > >> Hi, > >> > >> I beleive there might be a $ too much in two lines or the arguemnts are > >> not properly shell quoted or something? > >> > >> make[7]: /usr/src/src.git/Makefile.inc1:526: warning: Invalid character > " > >> " in variable name "eval /usr/bin/svnliteversion /usr/src/src.git" > >> make[7]: /usr/src/src.git/Makefile.inc1:526: warning: Invalid character > " > >> " in variable name "echo r" > >> > >> Makes me wonder if svnliteversion magic is still needed? > >> > > > > No. It's unused. And a bit of a nop these days unless you happen to have > > svn still installed. I never see this error, though. Which shell are you > > using? > > > > https://reviews.freebsd.org/D52912 removes it. > > I don't think the shell (csh) matters; it's the output I presume: > > [/usr/src]% /usr/bin/svnliteversion /usr/src/src.git > Unversioned directory > > > -- > Bjoern A. Zeeb r15:7 [-- Attachment #2 --] <div dir="ltr">Oh! You have svnlite installed.<div><br></div><div>Warner</div></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Sun, Oct 5, 2025 at 2:10 AM Bjoern A. Zeeb <<a href="mailto:bzeeb-lists@lists.zabbadoz.net">bzeeb-lists@lists.zabbadoz.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Sat, 4 Oct 2025, Warner Losh wrote:<br> <br> > On Sat, Oct 4, 2025 at 2:37 PM Bjoern A. Zeeb <<br> > <a href="mailto:bzeeb-lists@lists.zabbadoz.net" target="_blank">bzeeb-lists@lists.zabbadoz.net</a>> wrote:<br> ><br> >> Hi,<br> >><br> >> I beleive there might be a $ too much in two lines or the arguemnts are<br> >> not properly shell quoted or something?<br> >><br> >> make[7]: /usr/src/src.git/Makefile.inc1:526: warning: Invalid character "<br> >> " in variable name "eval /usr/bin/svnliteversion /usr/src/src.git"<br> >> make[7]: /usr/src/src.git/Makefile.inc1:526: warning: Invalid character "<br> >> " in variable name "echo r"<br> >><br> >> Makes me wonder if svnliteversion magic is still needed?<br> >><br> ><br> > No. It's unused. And a bit of a nop these days unless you happen to have<br> > svn still installed. I never see this error, though. Which shell are you<br> > using?<br> ><br> > <a href="https://reviews.freebsd.org/D52912" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D52912</a>; removes it.<br> <br> I don't think the shell (csh) matters; it's the output I presume:<br> <br> [/usr/src]% /usr/bin/svnliteversion /usr/src/src.git<br> Unversioned directory<br> <br> <br> -- <br> Bjoern A. Zeeb r15:7</blockquote></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpO4_4DS2gdfZX-oKuADi7M=ic4SjgpAgjX1iMBK82LFw>