Date: Wed, 13 Mar 2002 02:13:13 +0100 (CET) From: Dan Lukes <dan@obluda.cz> To: FreeBSD-gnats-submit@freebsd.org Subject: bin/35836: Typo in ppp's mppe.c MPPEDispOpts output Message-ID: <200203130113.g2D1DD970719@xkulesh.vol.cz>
next in thread | raw e-mail | index | archive | help
>Number: 35836
>Category: bin
>Synopsis: Typo in ppp's mppe.c MPPEDispOpts output
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Mar 12 17:30:01 PST 2002
>Closed-Date:
>Last-Modified:
>Originator: Dan Lukes
>Release: FreeBSD 4.5-STABLE i386
>Organization:
Obludarium
>Environment:
System: FreeBSD 4.5-STABLE Sat Mar 2 15:16:06 CET 2002 dan@...:/usr/src/sys/compile/Dan i386
PPP: user-ppp 2.3.3 (built Mar 2 2002)
>Description:
The MPPEDispOpts incorrectly build description string when no
encryption requested by peer. It add "(0" string to buffer, but add 1 only
to buffer len, so '0' is overwritten by subsequent writes.
>How-To-Repeat:
enable CCP logging and connect to a PPP peer asking MPPC without
MPPE (it's implemented as ask for MPPE with MPPE_OPT_COMPRESSED bit set
but all MPPE_OPT_BITMASK bits cleared
>Fix:
--- mppe.c.ORIG Sun Sep 2 06:08:33 2001
+++ mppe.c Wed Mar 13 01:48:43 2002
@@ -372,7 +372,7 @@
len = strlen(buf);
if (!(val & MPPE_OPT_BITMASK)) {
snprintf(buf + len, sizeof buf - len, "(0");
- len++;
+ len+=2;
} else {
ch = '(';
if (val & MPPE_OPT_128BIT) {
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200203130113.g2D1DD970719>