Date: Tue, 5 Nov 2013 07:10:36 +0100 From: Olivier Duchateau <duchateau.olivier@gmail.com> To: Rostislav Krasny <rosti.bsd@gmail.com> Cc: freebsd-xfce@freebsd.org Subject: Re: vendorinfo file Message-ID: <CAHcdu2rr2j-_H9=wnz=DiD6ZwC7iRq2F6UDm_g%2BizLGZ3gmYRw@mail.gmail.com> In-Reply-To: <CANt7McF1RBpbvGae1AeY_n6YzLu-CvmeEJ%2BvJk%2Bc=vGY4h9R7A@mail.gmail.com> References: <CANt7McHHELPD57zCVZAJPk-Kk9-%2B7uaeuHa-qOPH4UwZgqNRnQ@mail.gmail.com> <CAHcdu2r3qSQQSdjSMZR_q38xOs1H_OaX-ooX2F0QEBN19_-xcg@mail.gmail.com> <CANt7McEyY0v5hrvFqSo3ezuDLuW=gNGQODjm2=1MLLeceOGyCg@mail.gmail.com> <CAHcdu2q7mM43SBgwVxyQ0Owpk%2B4c2L1X8SxpM5zcdG_pV1ffPw@mail.gmail.com> <CANt7McEK8CpDaJnfPaovo8Pd7=26V4FG_E3cLV4=WaA9SRon=w@mail.gmail.com> <CANt7McF1RBpbvGae1AeY_n6YzLu-CvmeEJ%2BvJk%2Bc=vGY4h9R7A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
2013/11/5 Rostislav Krasny <rosti.bsd@gmail.com>: > On Tue, Nov 5, 2013 at 12:45 AM, Rostislav Krasny <rosti.bsd@gmail.com> wrote: >> On Tue, Nov 5, 2013 at 12:22 AM, Olivier Duchateau >>> See commit log, here >>> http://git.xfce.org/xfce/libxfce4ui/commit/xfce4-about/main.c?id=4a14ef81cdc6f3e45b63eb42ca41c6af50c9c0c4 >> >> See the full version of this file. If the VENDOR_INFO macro isn't >> defined, all that vendor specified code is disabled. >> >> http://git.xfce.org/xfce/libxfce4ui/tree/xfce4-about/main.c >> >> And according to libxfce4ui/tree/configure.ac.in the VENDOR_INFO seems >> to be defined only when '--with-vendor-info' is used with some not >> empty value. > > Finally I tested it by changes attached in the libxfce4menu.diff file. > After this change the xfce4-about program shows no vendor information > (neither vendor name in the version text nor vendor tab) and doesn't > print any warning in the console it is ran from. > > I don't insist in this change. If you want to keep > '--with-vendor-info=FreeBSD' and to add some vendorinfo file with > FreeBSD about and advertising information, it would be nice too. Just > make a choice. I disagree with you, new tab will be created if length of file is greater than zero. If file doesn't exists or is empty nothing append (see xfce_about_vendor() function). --with-vendor-info=FreeBSD is used in main() function (from line 482) as xfce_about_vendor() doesn't initialize new tab, OS is only display. -- olivier
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHcdu2rr2j-_H9=wnz=DiD6ZwC7iRq2F6UDm_g%2BizLGZ3gmYRw>