Date: Wed, 19 Aug 1998 22:50:00 -0700 (PDT) From: Michael Smith <msmith@FreeBSD.ORG> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: cvs commit: src/sys/i386/isa if_wl.c Message-ID: <199808200550.WAA28557@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
msmith 1998/08/19 22:50:00 PDT
Modified files:
sys/i386/isa if_wl.c
Log:
A better fix for kern/7144:
The check for dropping unicast packets not sent to our ethernet
address is after the bpf tap, but not conditioned on it. All packets
received should get handed to bpf, and unicast packets not to us (mac)
should get dropped whether or not there is a bpf listener. I believe
that the common optimization that the interface is in hw promisc mode
iff there is a bpf listener is in general wrong, but more frequently
so on wavelans.
I think Max's fix makes bpf listeners not see unicast packets sent to
others, but I'm not sure.
One can argue that checking on MOD_ENAL is wrong, but the code only
drops packets that shouldn't be received. The correctness condition
is that it be run whenever unicast packets without our mac address can
be received.
PR: kern/7144
Submitted by: Greg Troxel <gdt@ir.bbn.com>
Revision Changes Path
1.14 +28 -36 src/sys/i386/isa/if_wl.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199808200550.WAA28557>