Date: Fri, 31 Jul 2009 13:28:27 -0400 From: John Baldwin <jhb@freebsd.org> To: Sam Leffler <sam@errno.com> Cc: svn-src-head@freebsd.org, Ed Schouten <ed@80386.nl>, svn-src-all@freebsd.org, src-committers@freebsd.org, Rui Paulo <rpaulo@freebsd.org> Subject: Re: svn commit: r195907 - in head/sys: amd64/amd64 i386/i386 Message-ID: <200907311328.28681.jhb@freebsd.org> In-Reply-To: <4A73232D.8050605@errno.com> References: <200907271351.n6RDptNX002239@svn.freebsd.org> <20090731150328.GN1292@hoeg.nl> <4A73232D.8050605@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 31 July 2009 1:00:29 pm Sam Leffler wrote:
> Ed Schouten wrote:
> > * Rui Paulo <rpaulo@FreeBSD.org> wrote:
> >> Refine the MacBook hack to only match early models that have Intel ICH.
> > ...
> >> - if (strncmp(sysenv, "MacBook", 7) == 0) {
> >> + if (strncmp(sysenv, "MacBook1,1", 10) == 0 ||
> >> + strncmp(sysenv, "MacBookPro1,1", 13) == 0 ||
> >> + strncmp(sysenv, "MacBookPro1,2", 13) == 0 ||
> >> + strncmp(sysenv, "Macmini1,1", 10) == 0) {
> >
> > Yay -- this change broke FreeBSD on my MacBook3,1. Could we please add
> > MacBook3,1 to this list before releasing 8.0?
> >
>
> A hack like this deserves a loader tunable to set the list or, perhaps
> easier, an extra model ID to allow workaround w/o rebuilding (e.g. for
> doing an install).
Or just a tunable to force it on: 'machdep.disable_ich_smi' or some such.
Note that different ICH store PMBASE in different places. It's in a
different register in the ICH10 for example (PCI config register 0x44 vs 0x40
on older ICHs).
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200907311328.28681.jhb>