Date: Tue, 20 Aug 2019 23:12:40 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Mark Millard <marklmi@yahoo.com> Cc: svn-src-head@freebsd.org Subject: Re: svn commit: r351253 - in head/contrib/libc++: include src Message-ID: <36651EB6-E3B5-4E4F-A445-825B638A2DED@FreeBSD.org> In-Reply-To: <416E4F6E-A073-4B0E-A67D-EFAC4769E3AD@yahoo.com> References: <416E4F6E-A073-4B0E-A67D-EFAC4769E3AD@yahoo.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 20 Aug 2019, at 23:02, Mark Millard <marklmi@yahoo.com> wrote: > >> Author: dim >> Date: Tue Aug 20 17:39:32 2019 >> New Revision: 351253 >> URL: >> https://svnweb.freebsd.org/changeset/base/351253 >> >> >> Log: >> Pull in r368867 from upstream libc++ trunk (by Marshall Clow): >> >> Rework recursive_timed_mutex so that it uses __thread_id instead of >> using the lower-level __libcpp_thread_id. This is prep for fixing >> PR42918. Reviewed as >> https://reviews.llvm.org/D65895 >> >> >> Pull in r368916 from upstream libc++ trunk (by Marshall Clow): >> >> Fix thread comparison by making sure we never pass our special 'not a >> thread' value to the underlying implementation. Fixes PR#42918. > > FYI: llvm's -r368916 has a successor fix: -r329399 tied to: > > https:://reviews.llvm.org/D66480 > > that is summarized with: > > QUOTE > In fixing https://bugs.llvm.org/show_bug.cgi?id=42918 (r368916), I broke external threading support. > This should fix that > END QUOTE Yes, I saw that, but as far as I know, we do not use any form of external threading. At some point we will import this with a wholesale update. -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCXVxiSAAKCRCwXqMKLiCW o/4zAKCnEEOHOGoaeATrkcuzRmihD+PBPACffrDfzua652/JF2HUVS/gSZaKTlM= =qcmJ -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?36651EB6-E3B5-4E4F-A445-825B638A2DED>