Date: Tue, 9 Jun 2009 19:47:43 +0400 From: Stanislav Sedov <stas@FreeBSD.org> To: pav@FreeBSD.org Cc: cvs-ports@FreeBSD.org, beech@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.port.mk Message-ID: <20090609194743.c9d9bcc8.stas@FreeBSD.org> In-Reply-To: <1244560269.33181.8.camel@pav.hide.vol.cz> References: <200901111104.n0BB45Rj058235@repoman.freebsd.org> <20090609190633.38393ea1.stas@FreeBSD.org> <1244560269.33181.8.camel@pav.hide.vol.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, 09 Jun 2009 17:11:09 +0200 Pav Lucistnik <pav@FreeBSD.org> mentioned: > Stanislav Sedov píše v út 09. 06. 2009 v 19:06 +0400: > > > > - Fix COPYTREE_* macros not to change permissions and ownership on files, that > > > were already present in the target path > > > > > > Submitted by: beech > > > > This breaks a lot of ports at least on 7-STABLE. GNU CPIO changes permissions > > to 0700 on the parent (and probably other) directoried in copy-out mode. After > > this change these directories end up with permissions 0700 instead of 755 as > > before. I think at least the part that changed permissions for directories > > in the target dir to 0755 should be restored. > > > > I've not checked if the HEAD cpio shows the same behaviour as GNU cpio yet. > > This would certainly be clearly visible on the exp-run. Can you send me > a test-case? > The port that currently fails for me is ruby-locale2. But I'm able to reproduce this with any port that uses copytree on 7.2. You can check this by hand by running `cpio -dumpl * some_dir/` where some_dir already exists. You should end up with permissions 0700 on that dir. I'll try to dig deeper on evening. > BTW find -exec chmod 755 is still part of the code... > Yeah, but it only fix permissions on files that have been actually installed... -- Stanislav Sedov ST4096-RIPE [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJKLoQfAAoJEKN82nOYvCd0fHQP/2rSWCtybbgqWccU3RIRuqfW 5zQIVmQQAKdHYigi0waCGXkRd50fTh8ftqgM5ARRtdIfvf8JPXDKKXV0ccZ0QEI/ gFUi/xv7EuVVYuGS1JB2f19kz6aTBul/UIXdTnYUaer/h4K3xljmP4Bz+Rr6t4S4 QP2HWS0Q4tfWy6kmIJqG9v7sG7iO2V5W2EW2kyrj316VP3QfzBXXFQAf00gOVsUr rN7tJCBCN/vi4eGU9a1Vk3mK6zGZTlQkeonlFLjG9gUodorsaHauLjOvfqDyaruZ sJLtZ2a3tToTDcpnc5+t6aXjZGR3hCraO+TEXYUqnHLeRVNB9OmUQf94gC0pXpN2 wfQRvjSUSKxqlhYy5c22b4ZuTXtE5NI+fw0EPiwXac3zT2qDyBL3lwgWH6y3b2Od OFo05Fm4pge9lmO9qHR7JAtE2h8dqHtsjSQGiE/LNehtnB9DJ5L6rBuobpiJHQ7+ i4uurNTwsbTNjQ6X+iBzkiT2MG5pHtdRz4PpbkCaePzNu27c/+8kvYavJ7qgYaQZ Bc+ump5YDlzss+cgwv+n7vo4rP9XYsAqbMm9Br5KIqc2cajbXF/26rHaA/AiHpJf s2u8MbqvuxdyPOfaxm0vEwGSou0GpP/LkfH6HIMjlya81Zz16o6dWOp9ZXtSu29d nljucAvFycUn/KJlVp5n =r5ry -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090609194743.c9d9bcc8.stas>