Date: Thu, 6 Jan 2005 11:57:19 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Giorgos Keramidas <keramida@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: human-readable swap partition sizes with pstat -sh Message-ID: <20050106195719.GB24896@odin.ac.hmc.edu> In-Reply-To: <20050106191201.GA30826@gothmog.gr> References: <20050106191201.GA30826@gothmog.gr>
next in thread | previous in thread | raw e-mail | index | archive | help
--0eh6TmSyL6TZE2Uz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 06, 2005 at 09:12:01PM +0200, Giorgos Keramidas wrote: > The following patch adds support for human-readable partition sizes in > pstat -s and swapinfo output, when the -h option is used: >=20 > gothmog:/d/src/usr.sbin/pstat$ ./pstat -s > Device 1K-blocks Used Avail Capacity > /dev/ad1s1b 5120000 12 5120000 0% >=20 > gothmog:/d/src/usr.sbin/pstat$ ./pstat -sh > Device 1K-blocks Used Avail Capacity > /dev/ad1s1b 5120000 12K 4.9G 0% >=20 > Does anyone have comments or suggestions for further improvement? Look good in general. Does -kh make sense? I think so since it would force the blocks line, but I'm not 100% sure. On minor, mostly style nit is that while intmax_t is 64-bits, nothing requires that so you should probably have conver return an int64_t. I'd argue that we might want to replace the int64_t in humanize_number with intmax_t since that wouldn't change the ABI (or API due to implicit casts), but would mean we wouldn't have to add a humanize_number128 later if some architecture grows 128-bit ints for some reason or another. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --0eh6TmSyL6TZE2Uz Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFB3ZgeXY6L6fI4GtQRAoixAJoDZtmnNe/KCvfNkUp3sRkFPrPmUACgp5jr 2+M/dAC7S04dIMIrFBaetME= =PA3X -----END PGP SIGNATURE----- --0eh6TmSyL6TZE2Uz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050106195719.GB24896>