Date: Fri, 5 Mar 2010 17:05:18 +0200 From: Ion-Mihai Tetcu <itetcu@FreeBSD.org> To: Anton Berezin <tobez@tobez.org> Cc: Wen Heping <wen@freebsd.org>, cvs-ports@freebsd.org, wen heping <wenheping@gmail.com>, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/devel/p5-Make-Cache Makefile distinfo Message-ID: <20100305170518.1e97858c@it.buh.tecnik93.com> In-Reply-To: <20100305133853.GD7708@heechee.tobez.org> References: <201003050042.o250gscP075349@repoman.freebsd.org> <20100305091220.GB7708@heechee.tobez.org> <7be7a2801003050454m3258b2aandca5cc60195d9d9a@mail.gmail.com> <20100305133853.GD7708@heechee.tobez.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, 5 Mar 2010 14:38:53 +0100 Anton Berezin <tobez@tobez.org> wrote: > On Fri, Mar 05, 2010 at 08:54:31PM +0800, wen heping wrote: > > On Fri, Mar 5, 2010 at 5:12 PM, Anton Berezin <tobez@tobez.org> > > wrote: > > > On Fri, Mar 05, 2010 at 12:42:54AM +0000, Wen Heping wrote: > > >> wen 2010-03-05 00:42:54 UTC > > >> > > >> FreeBSD ports repository > > >> > > >> Modified files: > > >> devel/p5-Make-Cache Makefile distinfo > > >> Log: > > >> - Update to 1.052 > > >> > > >> Feature safe: yes > > > > > > In my tests, this version failed its own regression tests under > > > either one of the following two conditions: when a recent > > > p5-Storable is installed, or when using perl 5.10.1. I suspect > > > that in practice this is the same condition, since the version of > > > Storable.pm supplied with perl 5.10.1 (2.20) is more recent than > > > the version of Storable.pm installed with perl 5.8.9 (2.19). > > > > > > I understand that it is not realistic to expect that you would > > > test it with and without p5-Storable installed. On the other > > > hand, at the very least, I would expect that 1) the distribution > > > tests are run before commit, and 2) they are run with *both* > > > lang/perl5.8 and lang/perl5.10. > > > > Yes, the regression test failed. :( > > > > Can we make bsd.perl.mk support "make test" ? > > While it would be useful, is it really needed? > > ( cd `make -V WRKSRC` ; make test ) > > works just as well, not even mentioning all sorts of possible > automation of the building and testing process. I'd argue for enabling it globally based on some env var. This way we could easily have it run on test systems (e.g. QAT, pointy exp runs, etc). -- IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEUEARECAAYFAkuRHa8ACgkQJ7GIuiH/oeXsWQCXcGUmUqjs4RWxUvteuwdX2ijA oACff4VByrGebqCB7wm2OxEAtkgEdME= =dvt+ -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100305170518.1e97858c>