Date: Sun, 14 May 1995 13:22:53 -0700 (PDT) From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com> To: nate@trout.sri.MT.net (Nate Williams) Cc: nate@freefall.cdrom.com, CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com Subject: Re: cvs commit: src/sys/sys mman.h Message-ID: <199505142022.NAA04490@gndrsh.aac.dev.com> In-Reply-To: <199505142015.OAA23760@trout.sri.MT.net> from "Nate Williams" at May 14, 95 02:15:31 pm
next in thread | previous in thread | raw e-mail | index | archive | help
>
> > > nate 95/05/14 12:19:08
> > >
> > > Modified: sys/sys mman.h
> > > Log:
> > > Prototype for madvise() is missing from sys/mman.h
> > >
> > > Submitted by: Kai Vorma <vode@snakemail.hut.fi>
> >
> > BANG!!! From the FREEZE document:
> >
> > 2) All kernel bug fixes are to be reviewed by David Greenman *before*
> > they are committed.
>
> This isn't a *kernel* bug fix, and *couldn't* possibly cause any sort of
> kernel problems since madvise() is a user function. Prototyping a
> function can only be considered a bug-fix and nothing else.
If the code lives in /usr/src/sys, it *IS* a kernel change, no if's and's
or buts about it.
Madvice is implemented in the kernel via a system call isn't it??
thump:rgrimes {148} kfind -i madvise
./kern/init_sysent.c:int madvise();
./kern/init_sysent.c: { 3, madvise }, /* 75 = madvise */
./kern/syscalls.c: "madvise", /* 75 = madvise */
./kern/syscalls.master:75 STD 3 BSD madvise
./sys/mman.h: * Advice to madvise
./sys/syscall-hide.h:HIDE_BSD(madvise)
./sys/syscall.h:#define SYS_madvise 75
./vm/vm_extern.h:int madvise __P((struct proc *, void *, int *));
./vm/vm_mmap.c:struct madvise_args {
./vm/vm_mmap.c:madvise(p, uap, retval)
./vm/vm_mmap.c: struct madvise_args *uap;
thump:rgrimes {149}
Note we already had a prototype for it in vm/vm_extern.h. This was also
a non-critical item.
--
Rod Grimes rgrimes@gndrsh.aac.dev.com
Accurate Automation Company Custom computers for FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199505142022.NAA04490>