Date: Mon, 08 Nov 2010 09:42:49 -0700 From: Warner Losh <imp@bsdimp.com> To: freebsd-embedded@FreeBSD.org Subject: Re: Review request: iicbus_transfer_gen() repeated start support Message-ID: <4CD82889.3020602@bsdimp.com> In-Reply-To: <AANLkTinp_0U4mY-HYR%2B1NcqXqZ7yLz8e4e44WE=%2BZLK2@mail.gmail.com> References: <4C0BB887.5070103@freebsd.org> <AANLkTinp_0U4mY-HYR%2B1NcqXqZ7yLz8e4e44WE=%2BZLK2@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/07/2010 20:37, Andrew Thompson wrote: > On 7 June 2010 03:02, Nathan Whitehorn<nwhitehorn@freebsd.org> wrote: >> I committed yesterday some changes to the iicbus_transfer() API that allow >> using that interface to send messages containing repeated starts. The >> attached patch implements this for the iicbus_transfer_gen() case, but I >> don't have any I2C controllers that use this routine, so I can't test it. I >> would much appreciate it if someone could review and test the patch for me. >> -Nathan > I have tested this and nothing broke. The i2c devices+drivers on my > board do not use IIC_M_NOSTART or IIC_M_NOSTOP flags so couldn't > verify that part of it. I'll have to try things on my AT91 box too. Do the upper layers need to warn about IIC_M_NOSTART/IIC_M_NOSTOP flags not being supported? Or have some way for userland to know they can issue the ioctl? Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CD82889.3020602>