Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Dec 2013 09:51:03 -0500
From:      Glen Barber <gjb@FreeBSD.org>
To:        Hiroki Sato <hrs@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   Re: svn commit: r258848 - user/hrs/releng/release
Message-ID:  <20131202145103.GG1839@glenbarber.us>
In-Reply-To: <201312021440.rB2EeQa6012210@svn.freebsd.org>
References:  <201312021440.rB2EeQa6012210@svn.freebsd.org>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On Mon, Dec 02, 2013 at 02:40:26PM +0000, Hiroki Sato wrote:
> Author: hrs
> Date: Mon Dec  2 14:40:26 2013
> New Revision: 258848
> URL: http://svnweb.freebsd.org/changeset/base/258848
> 
> Log:
>   Improve robustness and consistency, and remove redundant lines with no
>   major functional change:

> [...]

> +if [ $($ID -u) -ne 0 ]; then
> +	echo 1>&2 "$0: Needs to be run as root."
> +	exit 1
> +fi
>  # The directory within which the release will be built.
> -CHROOTDIR="/scratch"
> +: ${CHROOTDIR:=/scratch}
> +: ${CHROOT_CMD:=chroot $CHROOTDIR}
> +: ${DESTDIR=:/R/}
> +: ${MAKEOBJDIRPREFIX:=/usr/obj}
>  

Please do not merge these changes to head/.  It was intentional that
environment was not honored, as everything should be set in the
configuration file.

It is possible to use the environment in the configuration file, such
as:

---- release.conf ----
: ${_DESTDIR=:/R/}
DESTDIR=${_DESTDIR}
---- release.conf ----

Glen


[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iQIcBAEBCAAGBQJSnJ5XAAoJELls3eqvi17QvskQAKLDKZEnISVFUp/uzdZqQI0v
WF1GVblsc+l4q1aNAEFarJp8RkZopKPpytBjt9RZHxkpuNcTlMlqhRm19rAbgH99
0wm2j018HAjEZr0Rk+/p1xyMn6pnLdH5vb0bZC9P/qA3qm7ueWOOEcee2fdA5q3O
n16kBWWaZBjaQ9oZi8wTxbigYyms7o1t/Nkde8sjjwO3hWXENLKNbRmVC00PwGKz
zwG/gie8ornERdFdNTDuDHxmpuNTdoJnjl7Aqmf5hPBAXG/FSyUC4v8Swm68bnWd
w7lCmSMYc6yrHmvXve6kv+O1RlHz/aFj8To4BujpBV7WccwkfPg+UbmCQuxN1Qij
nTMemkw8s7PYHXwVTCYuNAT7YD3LmobpZzhHoR1C85Q+/VBlTL8Jc2buM8WLSLor
MuIvu27fO9HmDccCez/RhPvB9dsQyJEHgMvfJZlMwK9Y4o4/BE4hND9+5I2dGi7O
bgFS/tEWkJ+jry8vdtg0VbbnOu+7vcr39OMOcVhPP2KN6d6PTfR1zF+71765KXcj
3RwKbhUBZZzIgFBg9bqRkIiahrvMg6/5GOOJFWzDS63Li7waFZfGUZfRFEIRD44x
J461CPPfzLVRguznqiFNP2AzMhzhJ5H/bTBsw3zUeN42VGI6CA+AWnHT7Qbc1he6
TctFI6w7jDUNHjhcRrjr
=tDnl
-----END PGP SIGNATURE-----
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131202145103.GG1839>