Date: Tue, 11 Sep 2001 14:48:12 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Matt Dillon <dillon@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/gnu/libexec/uucp/cu Makefile src/gnu/libexec/uucp/uucp Makefile src/gnu/libexec/uucp/uuname Makefile src/gnu/libexec/uucp/uustat Makefile src/gnu/libexec/uucp/uux Makefile src/usr.bin/tip/tip Makefile Message-ID: <20010911144812.B43697@sunbay.com> In-Reply-To: <20010911131419.B47107@ringworld.oblivion.bg>; from roam@ringlet.net on Tue, Sep 11, 2001 at 01:14:19PM %2B0300 References: <200109102230.f8AMUS561400@freefall.freebsd.org> <20010911101209.B4979@sunbay.com> <20010911131419.B47107@ringworld.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 11, 2001 at 01:14:19PM +0300, Peter Pentchev wrote: > On Tue, Sep 11, 2001 at 10:12:09AM +0300, Ruslan Ermilov wrote: > > It was clear that this is the "MFC to RELENG_4_3 security branch". > > It would be more informational to tell what this actually does. > > > > BTW, INSTALLFLAGS+= is the style bug, it should be written as > > INSTALLFLAGS=. INSTALLFLAGS are left to individual Makefiles, > > like SRCS, PROG, MAN, hence Makefile should initialize them. > > CFLAGS on the contrast aren't. > > INSTALLFLAGS+= allows the user to specify different (additional) > flags on the command line. > This isn't useful in the general sense (for the entire /usr/src trip). Also, changing INSTALLFLAGS after .include <bsd.prog.mk> doesn't work, as it is used in the assignment. Before this change, this looked like this: bin/rcp/Makefile:INSTALLFLAGS=-fschg gnu/usr.bin/man/man/Makefile:INSTALLFLAGS+= -fschg kerberos5/usr.bin/k5su/Makefile:INSTALLFLAGS=-fschg libexec/rtld-aout/Makefile:INSTALLFLAGS+= -fschg -C libexec/rtld-elf/Makefile:INSTALLFLAGS= -fschg -C -b sbin/init/Makefile:INSTALLFLAGS=-fschg -b -B.bak usr.bin/login/Makefile:INSTALLFLAGS=-fschg usr.bin/opieinfo/Makefile:INSTALLFLAGS=-fschg usr.bin/opiepasswd/Makefile:INSTALLFLAGS=-fschg usr.bin/rlogin/Makefile:INSTALLFLAGS=-fschg usr.bin/rsh/Makefile:INSTALLFLAGS=-fschg usr.bin/su/Makefile:INSTALLFLAGS=-fschg usr.sbin/cron/crontab/Makefile:INSTALLFLAGS=-fschg usr.sbin/moused/Makefile:#INSTALLFLAGS=-fschg usr.sbin/sliplogin/Makefile:INSTALLFLAGS=-fschg Note, there were only two exceptions to this rule. If you want to install your world with -C, you way want to change the INSTALL, as documented in make.conf(5). Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010911144812.B43697>