Date: Thu, 2 Jun 2005 09:17:22 +0000 (UTC) From: Hartmut Brandt <harti@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/usr.bin/make suff.c Message-ID: <200506020917.j529HMKQ033943@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
harti 2005-06-02 09:17:22 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_5)
usr.bin/make suff.c
Log:
Fix a bug in suffix parsing. Under certain circumstances the code
would access memory before the beginning of the string to match (the
suffix match starts from the end of both the suffix and the string
to match and proceedes until either the start of the suffix is hit or
the character does not match). This could lead to a memcpy copying
into random memory. This leads to make dumping core on amd64 (on i386
the overwritten memory for some reason does not cause a core dump).
Fix this by checking the length of the string too.
MFC of: 1.57
Submitted by: Matt Dillon <dillon@apollo.backplane.com>
Tested by: Julian H. Stacey <jhs@flat.berklix.net>
MFC after: 2 weeks
Revision Changes Path
1.29.2.1 +13 -9 src/usr.bin/make/suff.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200506020917.j529HMKQ033943>