Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Feb 2019 13:49:53 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        rgrimes@freebsd.org
Cc:        "Simon J. Gerraty" <sjg@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r344567 - in head: etc/mtree include sbin sbin/veriexec
Message-ID:  <20190226134953.GB39566@FreeBSD.org>
In-Reply-To: <201902260619.x1Q6Jjn2043418@pdx.rh.CN85.dnsmgr.net>
References:  <201902260617.x1Q6HOra098699@repo.freebsd.org> <201902260619.x1Q6Jjn2043418@pdx.rh.CN85.dnsmgr.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 25, 2019 at 10:19:45PM -0800, Rodney W. Grimes wrote:
> > Author: sjg
> > Date: Tue Feb 26 06:17:23 2019
> > New Revision: 344567
> > URL: https://svnweb.freebsd.org/changeset/base/344567
> > 
> > Log:
> >   Add verifying manifest loader for mac_veriexec
> >   
> >   This tool will verify a signed manifest and load contents into
> >   mac_veriexec for storage
> >   
> >   Sponsored by:	Juniper Networks
> >   Differential Revision:	D16575
> 
> Just a small nit, for future reference, from the template:
> > Differential Revision:    https://reviews.freebsd.org/D###
> (*full* phabric URL needed).

IMHO we should just fix the scripts to accept D#### alone, without
the URL.  We don't do that for PR (bugzilla) references, and the fact
that we do for the phab is both needless and confusing.  Also, that
URL might change one day while we could probably keep the old numbers
if we move.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190226134953.GB39566>