Date: Sat, 17 Dec 2011 19:05:08 +0000 From: Chris Rees <crees@freebsd.org> To: Jan Beich <jbeich@tormail.net> Cc: Christer Solskogen <christer.solskogen@gmail.com>, freebsd-ports <freebsd-ports@freebsd.org>, garga@freebsd.org Subject: Re: Removal of use_gmake breaks lua Message-ID: <CADLo838V8NKnX4s7i-vx7sn0QdeFWA2z0Mw4qQqgoyoOEEoH9g@mail.gmail.com> In-Reply-To: <1RbzOV-000AQU-65@internal.tormail.net> References: <CAMVU60aj2jZK6NWWpYK=Ub2qhUU4kEdGPKxGqjLyUoSDC%2Bu3Uw@mail.gmail.com> <CADLo8382u95a1BvBZ6SGBTKPjwmCMC2b=QB7xvq31zYMfcY2jA@mail.gmail.com> <1RbxBi-0008Ls-5O@internal.tormail.net> <CADLo83_6ALN5YyF-E9i_%2Bn8XH-qNeoAfKnYeZcqks3du7Jd8tA@mail.gmail.com> <1RbzOV-000AQU-65@internal.tormail.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17 December 2011 18:53, Jan Beich <jbeich@tormail.net> wrote: > Chris Rees <crees@freebsd.org> writes: > >>> Chris Rees <crees@freebsd.org> writes: >>> >>>>> as seen here: >>>>> http://docs.freebsd.org/cgi/getmsg.cgi?fetch=3D295602+0+/usr/local/ww= w/db/text/2011/cvs-all/20111113.cvs-all >>>> >>>> I don't like the proposed solution; it's less hackish to just use >>>> gmake again; most people have it installed anyway.... >>> >>> A non-hackish solution would involve fixing sys.mk to guard against >>> recursive inclusion of __MAKE_CONF. bsd.port.mk is known to have >>> this when using make(1) for do-build. >>> >>> Not that I mind shoving the issue under the carpet by using gmake. > [...] >> >> Ah now there is a better solution :) > > It breaks non ports builds if the guard is propagated =A0via .MAKEFLAGS. > And one no longer can .if/.ifdef (in make.conf) innards of ports. > >> >> I'll see if we can get it in the tree. > > Nevermind, in case of lang/lua > > =A01/ sys.mk sets CFLAGS=3D from make.conf > =A02/ Makefile adds -fPIC to CFLAGS > =A03/ bsd.port.mk copies CFLAGS to MAKE_ENV > =A04/ sys.mk sets CFLAGS from make.conf again, > =A0 =A0 `=3D' overrides CFLAGS from environment > > A simple make(1) build doesn't export CFLAGS > > # Makefile > all: > =A0 =A0 =A0 =A0@cd foo && $(MAKE) > =A0 =A0 =A0 =A0@cd foo && CFLAGS=3D'$(CFLAGS)' $(MAKE) > > # foo/Makefile > all: > =A0 =A0 =A0 =A0@echo $(CFLAGS) So... can be worked around with using ?=3D in make.conf? If that's the case then no code needs changing :) Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo838V8NKnX4s7i-vx7sn0QdeFWA2z0Mw4qQqgoyoOEEoH9g>