Date: Wed, 26 Sep 2012 19:04:52 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Glen Barber <gjb@FreeBSD.org> Cc: Garrett Cooper <yanegomi@gmail.com>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240967 - head/release Message-ID: <20120926190451.GA92155@FreeBSD.org> In-Reply-To: <20120926184643.GD1309@glenbarber.us> References: <201209261804.q8QI4H9P069204@svn.freebsd.org> <CAGH67wTNNs1Rt-KS3FYKWCfAY77_0Dhix=9dhuA3nCydqHm_Gw@mail.gmail.com> <20120926184643.GD1309@glenbarber.us>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 26, 2012 at 02:46:43PM -0400, Glen Barber wrote:
> On Wed, Sep 26, 2012 at 11:44:07AM -0700, Garrett Cooper wrote:
> > > -: ${RELSTRING=`chroot $2 uname -s`-`chroot $2 uname -r`-`chroot $2 uname -p`}
> > > +if [ "x${OSVERSION}" == "x" ]; then
> >
> > This should be `=` in order to be backwards compatible with older
> > (pre-9.1) copies of /bin/sh
>
> This won't be going into pre-9.1 versions of FreeBSD.
Still, there is no need to spread this bogus syntax which we had erroneously
adoped.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120926190451.GA92155>