Date: Sun, 31 Dec 2006 14:53:00 +0200 From: Ion-Mihai "IOnut" Tetcu <itetcu@FreeBSD.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet tcp_subr.c Message-ID: <20061231145300.49313fe8@it.buh.tecnik93.com> In-Reply-To: <200612301603.kBUG3iRp078184@repoman.freebsd.org> References: <200612301603.kBUG3iRp078184@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sat, 30 Dec 2006 16:03:44 +0000 (UTC) Robert Watson <rwatson@FreeBSD.org> wrote: > rwatson 2006-12-30 16:03:44 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/netinet tcp_subr.c > Log: > Merge tcp_subr.c:1.251 from HEAD to RELENG_6: > > Fix race conditions on enumerating pcb lists by moving the > initialization (and where appropriate the destruction) of the pcb > mutex to the init/finit functions of the pcb zones. This allows > locking of the pcb entries and race condition free comparison of the > generation count. Rearrange locking a bit to avoid extra locking > operation to update the generation count in in_pcballoc(). > (in_pcballoc now returns the pcb locked) > > I am planning to convert pcb list handling from a type safe to a > reference count model soon. (As this allows really freeing the > PCBs) > Reviewed by: rwatson, mohans > > This was missed in jhb's earlier MFC, and lead to a panic when > creating TCP sockets. Thanks you ! I lost my last night plus part of the day trying to understand why a server suddenly panic'ed on boot :( Now I know :-) -- IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" BOFH excuse #152: My pony-tail hit the on/off switch on the power strip [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFFl7KtBX6fi0k6KXsRAn5WAKCoyHyGa91vSJwKRoDjecvQTpdtTQCcCnhN GjJyEj3yt+cJmPg5ORWO5tg= =xbST -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061231145300.49313fe8>