Date: Sun, 12 Jan 2014 23:02:16 +0100 From: freebsd@sysfault.org To: =?utf-8?B?UmVuw6k=?= Ladan <rene@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, python@freebsd.org, Ruslan Makhmatkhanov <cvs-src@yandex.ru> Subject: Re: [CFR] lang/python26 removal Message-ID: <20140112220216.GB49978@medusa.sysfault.org> In-Reply-To: <CADL2u4g9pEEEZygTFSJOEh3N=M15Z_EO5MuwHzr%2BoHKX7u9k5A@mail.gmail.com> References: <52C948C2.4080506@freebsd.org> <52CA91A3.8040309@yandex.ru> <CADL2u4ha9wWvdU76vG6CE-yA3xZ7VCC1tqi1-QtyebCSVQeBKQ@mail.gmail.com> <52CA9855.1060002@yandex.ru> <CADL2u4hVqSafxYhts%2BP3jLZgyfy%2B2djeBdi53_8V4MEWHttFcw@mail.gmail.com> <52CA9CE6.1020608@yandex.ru> <52CB0ED2.7030805@freebsd.org> <52CD912F.8010502@yandex.ru> <CADL2u4g9pEEEZygTFSJOEh3N=M15Z_EO5MuwHzr%2BoHKX7u9k5A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--lMM8JwqTlfDpEaS6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On, Thu Jan 09, 2014, Ren=C3=A9 Ladan wrote: > 2014/1/8 Ruslan Makhmatkhanov <cvs-src@yandex.ru>: > > Ren=C3=A9 Ladan wrote on 07.01.2014 00:15: > > > >> On 01/06/2014 13:09, Ruslan Makhmatkhanov wrote: > >>> > >>> Ren=C3=A9 Ladan wrote on 06.01.2014 16:00: > >>>> > >>>> 2014/1/6 Ruslan Makhmatkhanov <cvs-src@yandex.ru>: > >>>>> > >>>>> Ren=C3=A9 Ladan wrote on 06.01.2014 15:34: > >>>>> > >>>>>> 2014/1/6 Ruslan Makhmatkhanov <cvs-src@yandex.ru>: > >>>>>>> > >>>>>>> > >>>>>>> Ren=C3=A9 Ladan wrote on 05.01.2014 15:57: > >>>>>>> > >>>>>>>> Hi, > >>>>>>>> > >>>>>>>> lang/python26 expired a few days ago, so I patched > >>>>>>>> Mk/bsd.pyton.mk to > >>>>>>>> exclude lang/python26 and patched the USE_PYTHON* lines of all p= orts > >>>>>>>> referring to Python < 2.7. You must remove lang/python26 manually > >>>>>>>> to not > >>>>>>>> break INDEX. > >>>>>>>> > >>>>>>>> The patch is available at > >>>>>>>> http://people.freebsd.org/~rene/patches/python-to-27.diff > >>>>>>>> The bsd.python.mk patch itself is also here: > >>>>>>>> http://people.freebsd.org/~rene/patches/Mk__bsd.python.mk.diff > >>>>>>>> > >>>>>>>> mat@ already gave an "OK" for the USE_PYTHON* bumps. > >>>>>>>> > >>>>>>>> Does this patch and removing lang/python26 look OK to you? > >>>>>>>> > >>>>>>>> I'm not on python@ , so please CC me. > >>>>>>>> > >>>>>>>> Regards, > >>>>>>>> Ren=C3=A9 > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> I'd say please go on with that. But there is two things there, > >>>>>>> that would > >>>>>>> be > >>>>>>> great to be fixed before commiting: > >>>>>>> - value of 2 need to be used instead of 2.7 in USE_PYTHON in your > >>>>>>> patch > >>>>>> > >>>>>> > >>>>>> This is because I converted -2.7 to 2.7 etc. Are you saying that = all > >>>>>> USE_PYTHON*=3D2.7 should be converted to USE_PYTHON*=3D2 and that > >>>>>> other USE_PYTHON* values are OK ? > >>>>> > >>>>> > >>>>> > >>>>> I just looked at it again: > >>>>> > >>>>> -2.7 and 2.7 should be converted to just `2' > >>>>> 2.x+ should be converted to just `yes' to keep it's current meaning > >>>>> > >>>>> Will this `yes'-ports actually build with 3.x - that will be checked > >>>>> later > >>>>> for all the tree. I have plans for this. > >>>>> > >>>> I'll redo the patch with the above two conversion rules and blame any > >>>> breakage on you :-p > >>>> > >>>> Regards, > >>>> Ren=C3=A9 > >>> > >>> > >>> Ok). But please send it here for review). > >>> > >> Sure: http://people.freebsd.org/~rene/patches/python-cleanup.diff > >> > >> This patch looks (much) bigger than the previous patch but that is > >> because it includes the removal of lang/python26. > >> > >> Ren=C3=A9 > > > > > > Sorry, I see no changes we discussed earlier. Wrong patch-file? > > > Indeed I managed to upload the wrong file somehow. I re-uploaded the > file with the correct contents. > Looks good for me. Both solutions (explicit 2.7 or 2) work just fine. The latter pulls in lang/python2, but that does not hurt at all and ensures that (an unlikely) update for 2.8 is covered as well. Thanks for the hard work and doing the clean up! Cheers Marcus --lMM8JwqTlfDpEaS6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iEYEARECAAYFAlLTEOgACgkQi68/ErJnpke3uQCcDvuAqgriiLL/7C0xHFes47nm FNcAoIXkOlR51hJ417awbQgG/oWaEa/0 =A1YA -----END PGP SIGNATURE----- --lMM8JwqTlfDpEaS6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140112220216.GB49978>