Date: Fri, 30 Jan 2015 17:31:03 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Elizabeth Myers <elizabeth@interlinked.me> Cc: freebsd-current <freebsd-current@freebsd.org> Subject: Re: Questions on adding backlight support for the i915 driver Message-ID: <CAJ-VmokWhk4NEjkvzU-g4McA1d4=%2BBrFYgrzpLWUZ5yQawaKsQ@mail.gmail.com> In-Reply-To: <54CC2981.3040909@interlinked.me> References: <54C883E7.4000300@interlinked.me> <54CBA0A4.30708@FreeBSD.org> <54CC0999.90500@interlinked.me> <3595567.zVLW9tlg0N@ralph.baldwin.cx> <54CC2981.3040909@interlinked.me>
next in thread | previous in thread | raw e-mail | index | archive | help
On 30 January 2015 at 17:01, Elizabeth Myers <elizabeth@interlinked.me> wrote: > On 01/30/15 17:45, John Baldwin wrote: >> On Friday, January 30, 2015 04:45:45 PM Elizabeth Myers wrote: >>> On 01/30/15 09:17, John Baldwin wrote: >>>> Humm. If the code is going to live in the drm driver, then I would >>>> start with hanging a sysctl off of the drm device itself. (Each new-bus >>>> device_t has a sysctl ctx you can get to hang new nodes off of the >>>> device's node.) >>> I'm wondering if that's the correct place for it to live. So far it's >>> the only real place it *can* live that makes logical sense imho, unless >>> anyone has better ideas. >>> >>> This is awesome. As for upower, it should probably be patched to know >>> about other types of brightness sysctls if/when this is implemented. >> For now I think hanging it off of the device_t is fine. It can be moved >> later if there is an urgent need. However, I suspect that tools like upower >> will need updating regardless of where it ends up living. >> > > Now a more interesting question... the raw PCM backlight value used by > the hardware means that one can set the backlight to anything between 0 > and a specific number. On my system, it's 4882, and yes, there is a > subtle difference between the values. Is it best to expose this as a > percentage, or just have a read-only sysctl for max values? So, this is one of the discussions that popped up in the linux side of things, that we will end up eventually pulling into freebsd when the i915 code is updated. The raw value is (a) different per setup, and (b) may be inverted to work correctly. I also don't know if linear values along that spectrum map to linear brightness levels. So yeah, my suggestion we expose an ACPI/acpi_video like list of valid percentages, and let the user set them from 0-100%. That way the details of how the actual backlight values get derived are hidden from userland. -adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmokWhk4NEjkvzU-g4McA1d4=%2BBrFYgrzpLWUZ5yQawaKsQ>