Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Jun 2007 13:53:53 GMT
From:      John Baldwin <jhb@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 121574 for review
Message-ID:  <200706131353.l5DDrrVi012707@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=121574

Change 121574 by jhb@jhb_mutex on 2007/06/13 13:53:09

	Properly acquire Giant around vrele() of ktrace node if needed.

Affected files ...

.. //depot/projects/smpng/sys/kern/kern_exec.c#106 edit

Differences ...

==== //depot/projects/smpng/sys/kern/kern_exec.c#106 (text+ko) ====

@@ -747,8 +747,13 @@
 	if (ndp->ni_vp && error != 0)
 		vrele(ndp->ni_vp);
 #ifdef KTRACE
-	if (tracevp != NULL)
+	if (tracevp != NULL) {
+		int tvfslocked;
+
+		tvfslocked = VFS_LOCK_GIANT(tracevp->v_mount);
 		vrele(tracevp);
+		VFS_UNLOCK_GIANT(tvfslocked);
+	}
 	if (tracecred != NULL)
 		crfree(tracecred);
 #endif



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200706131353.l5DDrrVi012707>