Date: Thu, 06 May 2004 20:33:12 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: nate@root.org Cc: jhb@freebsd.org Subject: Re: cvs commit: src/sys/i386/i386 legacy.c src/sys/kern subr_smp.c Message-ID: <20040506.203312.01491062.imp@bsdimp.com> In-Reply-To: <20040506105124.O42462@root.org> References: <200405061554.i46Fs3q4023478@repoman.freebsd.org> <200405061241.42766.jhb@FreeBSD.org> <20040506105124.O42462@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20040506105124.O42462@root.org>
Nate Lawson <nate@root.org> writes:
: On Thu, 6 May 2004, John Baldwin wrote:
: > On Thursday 06 May 2004 11:54 am, Nate Lawson wrote:
: > > njl 2004/05/06 08:54:03 PDT
: > >
: > > FreeBSD src repository
: > >
: > > Modified files:
: > > sys/i386/i386 legacy.c
: > > sys/kern subr_smp.c
: > > Log:
: > > Move the CPU newbus attachment to i386 legacy. The acpi_cpu device will
: > > become just "cpu" and provide attachments in the !legacy case.
: > >
: > > Tested by: des
: >
: > By the way, it would be nice if the acpi_cpu(4) driver would still probe and
: > attach to devices for non-existent CPUs but just device_disable() the
: > associated device_t. This would keep the device from reprobing all the time.
:
: Good idea, I'll make that change tonight. The code I committed this
: morning returns ENXIO for them so probe will get called multiple times.
: Hmm, this may be more difficult than I first thought since some of the
: internal routines walk all devices in the devclass, operating on their
: resources. This change would require that code to have an extra case,
: "device here but not active". Right now it assumes that if the device is
: probed/attached, it is usable.
The device is already there. All the device_disable() would do would
keep it from being probed again.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040506.203312.01491062.imp>