Date: Mon, 23 Apr 2007 18:08:59 +0000 (UTC) From: John Baldwin <jhb@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern vfs_syscalls.c Message-ID: <200704231808.l3NI8x0h008491@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
jhb 2007-04-23 18:08:59 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_6)
sys/kern vfs_syscalls.c
Log:
MFC: Don't go to a whole lot of extra work to handle the race where the
new file descriptor is closed out from under us in kern_open(). This race
is already handled and the file will be closed when kern_open() does an
fdrop just before returning.
In addition, by handling the race early, this opens the code up to an
obscure bug where opening a devfs file could replace f_ops in the file
object so that fdrop() will try to close the vnode, but f_vnode never gets
set, so the vnode close routine panics due to the NULL f_vnode.
Revision Changes Path
1.392.2.18 +2 -25 src/sys/kern/vfs_syscalls.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200704231808.l3NI8x0h008491>